Bug 225224 - Avoid some null pointer dereferences in PlatformCALayer::drawLayerContents.
Summary: Avoid some null pointer dereferences in PlatformCALayer::drawLayerContents.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-29 21:48 PDT by Cameron McCormack (:heycam)
Modified: 2021-04-30 17:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2021-04-29 21:57 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2021-04-30 14:52 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2021-04-30 14:56 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-04-29 21:48:40 PDT 
<rdar://76359027>
Comment 1 Cameron McCormack (:heycam) 2021-04-29 21:57:55 PDT 
Created attachment 427398 [details]
Patch
Comment 2 Cameron McCormack (:heycam) 2021-04-29 22:09:36 PDT 
Comment on attachment 427398 [details]
Patch

Will split this into two patches.
Comment 3 Cameron McCormack (:heycam) 2021-04-30 14:52:23 PDT 
Created attachment 427453 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-04-30 14:53:39 PDT 
Comment on attachment 427453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427453&action=review

> Source/WebCore/ChangeLog:13
> +        setIsCALayerContext and setIsAcceleratedContext both assume (and assert)
> +        that the GraphicsContext has a platform context directly in m_data,
> +        but m_data is null when the GraphicsContext a display list recording
> +        context.  These calls are unnecessary when not working with a
> +        CG-backed GraphicsContext, so just skip them in this case.

This should probably mention DOM Rendering in GPUP
Comment 5 Cameron McCormack (:heycam) 2021-04-30 14:56:52 PDT 
Created attachment 427454 [details]
Patch
Comment 6 EWS 2021-04-30 17:43:14 PDT 
Committed r276866 (237212@main): <https://commits.webkit.org/237212@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427454 [details].