Bug 225222 - [Metal ANGLE]: fix webgl/2.0.0/deqp/functional/gles3/negativebufferapi
Summary: [Metal ANGLE]: fix webgl/2.0.0/deqp/functional/gles3/negativebufferapi
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-29 18:43 PDT by Kyle Piddington
Modified: 2021-04-30 18:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2021-04-29 18:47 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2021-04-30 09:53 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-04-29 18:43:55 PDT 
[Metal ANGLE]: fix webgl/2.0.0/deqp/functional/gles3/negativebufferapi
Comment 1 Kyle Piddington 2021-04-29 18:47:42 PDT 
Created attachment 427395 [details]
Patch
Comment 2 Kyle Piddington 2021-04-29 18:47:45 PDT 
<rdar://problem/77349908>
Comment 3 EWS Watchlist 2021-04-29 18:49:03 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Dean Jackson 2021-04-30 09:45:12 PDT 
Comment on attachment 427395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427395&action=review

> LayoutTests/ChangeLog:6
> +	Uniform buffers are implemented as 'constant' buffers in Metal. 

Is this a tab?
Comment 5 Kyle Piddington 2021-04-30 09:53:28 PDT 
Created attachment 427433 [details]
Patch
Comment 6 Kyle Piddington 2021-04-30 12:00:21 PDT 
 (In reply to Dean Jackson from comment #4)
> Comment on attachment 427395 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427395&action=review
> 
> > LayoutTests/ChangeLog:6
> > +	Uniform buffers are implemented as 'constant' buffers in Metal. 
> 
> Is this a tab?

Not anymore it's not :)
Comment 7 EWS 2021-04-30 18:22:55 PDT 
Committed r276869 (237215@main): <https://commits.webkit.org/237215@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427433 [details].