Bug 22522 - Add proper WML error handling
Summary: Add proper WML error handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 20393
  Show dependency treegraph
 
Reported: 2008-11-26 18:46 PST by Nikolas Zimmermann
Modified: 2008-11-26 21:09 PST (History)
0 users

See Also:


Attachments
Initial patch (24.18 KB, patch)
2008-11-26 20:49 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff
LayoutTest changes (15.80 KB, patch)
2008-11-26 20:50 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-11-26 18:46:45 PST
WML treats all errors as fatal errors. That means any error within a document needs to be presented as 'parsing' error by the tokenizer - just like to XML parsing errors.
Comment 1 Nikolas Zimmermann 2008-11-26 20:49:42 PST
Created attachment 25549 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-11-26 20:50:08 PST
Created attachment 25550 [details]
LayoutTest changes
Comment 3 George Staikos 2008-11-26 20:56:06 PST
Comment on attachment 25549 [details]
Initial patch

With minor comments: 

1) our error messages should really be localized
2) should use something like " if (pageState && !pageState->...)"
Comment 4 Nikolas Zimmermann 2008-11-26 21:09:06 PST
(In reply to comment #3)
> (From update of attachment 25549 [details] [review])
> With minor comments: 
> 
> 1) our error messages should really be localized
The other XML tokenizer error messages are handled the same. If it's a problem, it's a general problem, would need to investigate how Mac handles translation.

> 2) should use something like " if (pageState && !pageState->...)"
Fixed.

Landed in r38816.