Bug 225218 - _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext
Summary: _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-29 16:47 PDT by Jiewen Tan
Modified: 2021-04-30 13:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2021-04-29 16:50 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-04-29 16:47:08 PDT 
_WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext.
Comment 1 Jiewen Tan 2021-04-29 16:47:27 PDT 
rdar://76969220
Comment 2 Jiewen Tan 2021-04-29 16:50:13 PDT 
Created attachment 427387 [details]
Patch
Comment 3 Brent Fulgham 2021-04-30 12:43:34 PDT 
Comment on attachment 427387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146
> +    if (shouldUseAlternateAttributes() && !context) {

Looks like we should have noticed that this path didn't match the other verifyUser. :-( Looks good.
Comment 4 Jiewen Tan 2021-04-30 13:11:35 PDT 
Comment on attachment 427387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146
>> +    if (shouldUseAlternateAttributes() && !context) {
> 
> Looks like we should have noticed that this path didn't match the other verifyUser. :-( Looks good.

Yup, look over that there are now two architectures in macOS.
Comment 5 EWS 2021-04-30 13:17:09 PDT 
Committed r276851 (237202@main): <https://commits.webkit.org/237202@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427387 [details].