Bug 225210 - [macCatalyst] "Enter Full Screen" button in media controls disappears
Summary: [macCatalyst] "Enter Full Screen" button in media controls disappears
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-29 14:40 PDT by Devin Rousso
Modified: 2021-05-03 12:58 PDT (History)
8 users (show)

See Also:


Attachments
Patch (14.13 KB, patch)
2021-04-29 15:32 PDT, Devin Rousso
eric.carlson: review+
Details | Formatted Diff | Diff
Patch (14.25 KB, patch)
2021-05-03 12:15 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-04-29 14:40:35 PDT
.
Comment 1 Devin Rousso 2021-04-29 14:40:46 PDT
<rdar://problem/77010150>
Comment 2 Devin Rousso 2021-04-29 15:32:07 PDT
Created attachment 427378 [details]
Patch
Comment 3 Eric Carlson 2021-05-03 12:08:19 PDT
Comment on attachment 427378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427378&action=review

> Source/WebCore/ChangeLog:10
> +        must `webkitSupportsFullscreen`, which calls into `MediaPlayerPrivate::supportsFullscreen`.

?  s/must/must call/
Comment 4 Devin Rousso 2021-05-03 12:10:31 PDT
Comment on attachment 427378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427378&action=review

>> Source/WebCore/ChangeLog:10
>> +        must `webkitSupportsFullscreen`, which calls into `MediaPlayerPrivate::supportsFullscreen`.
> 
> ?  s/must/must call/

Heh I was trying to use `webkitSupportsFullscreen` as a verb 😅

I'll rephrase it so it's more clear.
Comment 5 Devin Rousso 2021-05-03 12:15:36 PDT
Created attachment 427585 [details]
Patch
Comment 6 EWS 2021-05-03 12:58:53 PDT
Committed r276918 (237260@main): <https://commits.webkit.org/237260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427585 [details].