Bug 225208 - REGRESSION (r275431): [iOS] fast/events/touch/ios/mouse-events-dispatch-with-touch.html is timing out
Summary: REGRESSION (r275431): [iOS] fast/events/touch/ios/mouse-events-dispatch-with-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-29 13:47 PDT by Aditya Keerthi
Modified: 2021-04-29 14:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2021-04-29 14:01 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch for landing (2.00 KB, patch)
2021-04-29 14:28 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-04-29 13:47:42 PDT 
...
Comment 1 Aditya Keerthi 2021-04-29 13:48:02 PDT 
<rdar://problem/77042369>
Comment 2 Aditya Keerthi 2021-04-29 14:01:59 PDT 
Created attachment 427374 [details]
Patch
Comment 3 Devin Rousso 2021-04-29 14:09:46 PDT 
Comment on attachment 427374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427374&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        Remove the `!needsQuirks()` check added in r275431 to restore the
> +        original test behavior.

Might be worth expanding on this a bit more by saying that the test overrides `MouseEventsSimulationEnabled` which is the first thing checked _before_ `needsQuirks()` inside `Quirks::shouldDispatchSimulatedMouseEvents` (and I could be wrong on this part, but also that `NeedsSiteSpecificQuirks` defaults to `false` in WebCore).
Comment 4 Aditya Keerthi 2021-04-29 14:28:31 PDT 
Created attachment 427375 [details]
Patch for landing
Comment 5 EWS 2021-04-29 14:56:14 PDT 
Committed r276803 (237171@main): <https://commits.webkit.org/237171@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427375 [details].