Bug 22520 - REGRESSION(r38768?): Two animation tests crashing on buildbot
Summary: REGRESSION(r38768?): Two animation tests crashing on buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords: LayoutTestFailure, Regression
Depends on:
Blocks: 22499
  Show dependency tree / graph
 
Reported: 2008-11-26 16:25 PST by Mark Rowe (bdash)
Modified: 2008-12-03 14:21 PST (History)
2 users (show)

See Also:

Attachments
Disable the transform-animation-event-destroy-element while the animation lifetime issue is being investigated. (4.33 KB, patch)
2008-12-01 18:21 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch to fix bug (1.93 KB, patch)
2008-12-02 10:53 PST, Chris Marrin 		hyatt: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2008-11-26 16:25:36 PST 
See <http://build.webkit.org/results/trunk-mac-intel-release/6243/results.html> for the failing tests.  They appear to have started with <http://build.webkit.org/changes/2756>.  A crash log can be seen at <http://build.webkit.org/results/trunk-mac-intel-release/6243/DumpRenderTree.crash.log>.
Comment 1 Mark Rowe (bdash) 2008-11-26 16:27:39 PST 
Leopard is showing a different test crashing on <http://build.webkit.org/results/trunk-mac-intel-pixel/568/results.html>.
Comment 2 Chris Marrin 2008-12-01 15:06:41 PST 
All these bugs are fixed by the patches for 22046 and 22052
Comment 3 Simon Fraser (smfr) 2008-12-01 17:46:10 PST 
This test is still crashing on the bot:
<http://build.webkit.org/builders/trunk-mac-intel-pixel/builds/647/steps/pixel-layout-test/logs/stdio>

animations/transform-animation-event-destroy-element.html -> crashed
Comment 4 Simon Fraser (smfr) 2008-12-01 17:52:21 PST 
Debug builds assert:
(/Volumes/InternalData/Development/webkit/WebKit.git/JavaScriptCore/wtf/ThreadingPthreads.cpp:205 void WTF::Mutex::lock())
Comment 5 David Levin 2008-12-01 18:21:16 PST 
Created attachment 25649 [details]
Disable the transform-animation-event-destroy-element while the animation lifetime issue is being investigated.
Comment 6 Alexey Proskuryakov 2008-12-02 01:14:18 PST 
For me, the crash reproduces on Tiger/PPC, but not on Leopard/Intel. Looks like an animation lifetime issue indeed, and not something directly related to mutex locking.
Comment 7 Chris Marrin 2008-12-02 10:53:46 PST 
Created attachment 25675 [details]
Patch to fix bug

Sorry, I should not have closed this. The other two patches are needed for this fix, but it needs one more thing, which is included in this patch.
Comment 8 Dave Hyatt 2008-12-03 11:24:31 PST 
Comment on attachment 25675 [details]
Patch to fix bug

r=me
Comment 9 Chris Marrin 2008-12-03 14:21:28 PST 
Sending        WebCore/ChangeLog
Sending        WebCore/page/animation/AnimationBase.cpp
Transmitting file data ..
Committed revision 38968.