Bug 225170 - Adopt AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification
Summary: Adopt AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-28 16:24 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-04-29 19:04 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.72 KB, patch)
2021-04-28 17:33 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (9.82 KB, patch)
2021-04-29 18:33 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-04-28 16:24:03 PDT
Adopt AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification
Comment 1 Jean-Yves Avenard [:jya] 2021-04-28 17:11:23 PDT
rdar://77086915
Comment 2 Radar WebKit Bug Importer 2021-04-28 17:11:34 PDT
<rdar://problem/77293208>
Comment 3 Jean-Yves Avenard [:jya] 2021-04-28 17:19:35 PDT
rdar://problem/77086915
Comment 4 Jean-Yves Avenard [:jya] 2021-04-28 17:19:50 PDT
<rdar://problem/77086915>
Comment 5 Jean-Yves Avenard [:jya] 2021-04-28 17:33:27 PDT
Created attachment 427314 [details]
Patch
Comment 6 Eric Carlson 2021-04-29 10:07:01 PDT
Comment on attachment 427314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427314&action=review

> Source/WebCore/ChangeLog:11
> +        The current handling of AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification is currently broken

s/The current handling/The handling/

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:974
> +    if (!trackId.isEmpty())
> +        reenqueSamples(trackId);

It might be worth logging an error if the track id isn't found.
Comment 7 Jean-Yves Avenard [:jya] 2021-04-29 18:33:30 PDT
Created attachment 427394 [details]
Patch
Comment 8 EWS 2021-04-29 19:04:37 PDT
Committed r276828 (237183@main): <https://commits.webkit.org/237183@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427394 [details].