Bug 225167 - Sampled Page Top Color: hook into painting logic instead of taking snapshots
Summary: Sampled Page Top Color: hook into painting logic instead of taking snapshots
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 224987
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-28 15:50 PDT by Devin Rousso
Modified: 2021-05-18 16:45 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-04-28 15:50:10 PDT 
Review feedback of Bug 224987 suggested that rather than using `snapshotFrameRect` (and `Document::hitTest` to check if that location is 3rd party) to get the color of pixels in the page, which can be expensive, we should hook into painting logic.

Doing so will also (likely) make it easier to support non-sRGB color spaces, as right now `snapshotFrameRect` always uses sRGB.
Comment 1 Radar WebKit Bug Importer 2021-04-28 18:00:07 PDT 
<rdar://problem/77295389>
Comment 2 Tim Horton 2021-05-14 15:21:00 PDT 
Compositing makes this ... hard.