Bug 225157 - Make sure webkitpy tests pass on Linux and on more Python versions
Summary: Make sure webkitpy tests pass on Linux and on more Python versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-28 11:15 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-29 02:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.75 KB, patch)
2021-04-28 11:29 PDT, Sam Sneddon [:gsnedders]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-28 11:15:33 PDT
We only actually run webkitpy tests in CI on macOS Big Sur, and we only run these with Python 2.7 + Python 3.8, and there's enough platform-specific code in webkitpy that it's unsurprising that some tests fail.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-28 11:29:10 PDT
Created attachment 427283 [details]
Patch
Comment 2 Jonathan Bedard 2021-04-28 15:35:48 PDT
Comment on attachment 427283 [details]
Patch

Looks good, although I don't have a Linux machine to test on handy.
Comment 3 EWS 2021-04-29 02:45:27 PDT
Committed r276762 (237151@main): <https://commits.webkit.org/237151@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427283 [details].
Comment 4 Radar WebKit Bug Importer 2021-04-29 02:46:17 PDT
<rdar://problem/77311316>