Bug 225154 - Add SPI to query whether a URL would be upgraded to HTTPS
Summary: Add SPI to query whether a URL would be upgraded to HTTPS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-28 09:57 PDT by Alex Christensen
Modified: 2021-04-28 12:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.80 KB, patch)
2021-04-28 09:57 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (6.78 KB, patch)
2021-04-28 10:06 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-04-28 09:57:00 PDT
Add SPI to query whether a URL would be upgraded to HTTPS
Comment 1 Alex Christensen 2021-04-28 09:57:59 PDT
Created attachment 427271 [details]
Patch
Comment 2 Alex Christensen 2021-04-28 09:58:02 PDT
<rdar://problem/77269904>
Comment 3 Geoffrey Garen 2021-04-28 10:03:28 PDT
Comment on attachment 427271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427271&action=review

r=me -- but let's consider another name

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:249
> ++ (BOOL)_shouldUpgradeToHTTPS:(NSURL *)url WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

I think I would call this _willUpgradeToHTTPS, since it's a question about what the WebView will do.
Comment 4 Alex Christensen 2021-04-28 10:06:14 PDT
Created attachment 427274 [details]
Patch
Comment 5 Alex Christensen 2021-04-28 12:00:41 PDT
r276727