Bug 225139 - [clang] Remove implicit cast related warnings
Summary: [clang] Remove implicit cast related warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-27 22:25 PDT by Basuke Suzuki
Modified: 2021-04-28 11:54 PDT (History)
3 users (show)

See Also:


Attachments
PATCH (1.48 KB, patch)
2021-04-27 22:27 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-04-27 22:25:48 PDT
Only happens when building debug.
Comment 1 Basuke Suzuki 2021-04-27 22:27:35 PDT
Created attachment 427239 [details]
PATCH
Comment 2 Darin Adler 2021-04-28 11:25:44 PDT
Comment on attachment 427239 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:490
> +    ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit)));

The cast here is OK, but this code is really strange.
Comment 3 Darin Adler 2021-04-28 11:27:01 PDT
Comment on attachment 427239 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review

>> Source/WebCore/layout/inlineformatting/InlineLine.cpp:490
>> +    ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit)));
> 
> The cast here is OK, but this code is really strange.

I would like someone to explain this assertion at some point.
Comment 4 EWS 2021-04-28 11:53:20 PDT
Committed r276726 (237127@main): <https://commits.webkit.org/237127@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427239 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-28 11:54:19 PDT
<rdar://problem/77277039>