RESOLVED FIXED 225135
[JSC] Optimize bound function calls 
https://bugs.webkit.org/show_bug.cgi?id=225135
Summary [JSC] Optimize bound function calls
Yusuke Suzuki
Reported 2021-04-27 20:47:12 PDT
[JSC] Optimize bound function calls
Attachments
Patch (57.37 KB, patch)
2021-04-27 20:47 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (73.45 KB, patch)
2021-04-30 22:34 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (76.68 KB, patch)
2021-05-01 00:31 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (76.76 KB, patch)
2021-05-01 00:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (82.18 KB, patch)
2021-05-01 01:45 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (84.09 KB, patch)
2021-05-01 03:20 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (84.02 KB, patch)
2021-05-01 12:03 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (106.27 KB, patch)
2021-05-01 20:46 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (106.38 KB, patch)
2021-05-10 03:05 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (106.38 KB, patch)
2021-05-10 03:12 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-04-27 20:47:41 PDT
Created attachment 427233 [details] Patch
Yusuke Suzuki
Comment 2 2021-04-30 22:34:13 PDT
Created attachment 427489 [details] Patch
Yusuke Suzuki
Comment 3 2021-05-01 00:31:36 PDT
Created attachment 427491 [details] Patch
Yusuke Suzuki
Comment 4 2021-05-01 00:40:03 PDT
Created attachment 427492 [details] Patch
Yusuke Suzuki
Comment 5 2021-05-01 01:45:07 PDT
Created attachment 427493 [details] Patch
Yusuke Suzuki
Comment 6 2021-05-01 03:20:34 PDT
Created attachment 427494 [details] Patch
Yusuke Suzuki
Comment 7 2021-05-01 12:03:21 PDT
Created attachment 427509 [details] Patch
Yusuke Suzuki
Comment 8 2021-05-01 20:46:56 PDT
Created attachment 427517 [details] Patch
Mark Lam
Comment 9 2021-05-01 22:02:57 PDT
Comment on attachment 427517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427517&action=review > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:764 > + RegisterID* emitCreateArgumentsButterflyExcludingThis(RegisterID* dst, RegisterID* count); Did you mean "target" instead of "count"? > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1939 > + return generator.emitCreateArgumentsButterflyExcludingThis(generator.finalDestination(dst), additionalCount.get()); Is the 2nd argument supposed to be "additionalCount"? This doesn't match the `@createArgumentsButterfly(this);` in FunctionPrototype.js.
Radar WebKit Bug Importer
Comment 10 2021-05-04 20:48:15 PDT
<rdar://problem/77539823>
Yusuke Suzuki
Comment 11 2021-05-10 01:29:40 PDT
Comment on attachment 427517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427517&action=review >> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:764 >> + RegisterID* emitCreateArgumentsButterflyExcludingThis(RegisterID* dst, RegisterID* count); > > Did you mean "target" instead of "count"? Changed to target. Yeah, "count" is the one from the old patch. >> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1939 >> + return generator.emitCreateArgumentsButterflyExcludingThis(generator.finalDestination(dst), additionalCount.get()); > > Is the 2nd argument supposed to be "additionalCount"? This doesn't match the `@createArgumentsButterfly(this);` in FunctionPrototype.js. Changed to target.
Yusuke Suzuki
Comment 12 2021-05-10 03:05:41 PDT
Created attachment 428162 [details] Patch
Yusuke Suzuki
Comment 13 2021-05-10 03:12:47 PDT
Created attachment 428163 [details] Patch
Yusuke Suzuki
Comment 14 2023-02-14 17:49:24 PST
Pull request: https://github.com/WebKit/WebKit/pull/10116
EWS
Comment 15 2023-02-15 01:30:58 PST
Committed 260303@main (d99a52c87599): <https://commits.webkit.org/260303@main> Reviewed commits have been landed. Closing PR #10116 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.