Bug 225135 - [JSC] Optimize bound function calls
Summary: [JSC] Optimize bound function calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-27 20:47 PDT by Yusuke Suzuki
Modified: 2023-02-15 01:31 PST (History)
8 users (show)

See Also:

Attachments
Patch (57.37 KB, patch)
2021-04-27 20:47 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (73.45 KB, patch)
2021-04-30 22:34 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (76.68 KB, patch)
2021-05-01 00:31 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (76.76 KB, patch)
2021-05-01 00:40 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (82.18 KB, patch)
2021-05-01 01:45 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (84.09 KB, patch)
2021-05-01 03:20 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (84.02 KB, patch)
2021-05-01 12:03 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (106.27 KB, patch)
2021-05-01 20:46 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (106.38 KB, patch)
2021-05-10 03:05 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (106.38 KB, patch)
2021-05-10 03:12 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-04-27 20:47:12 PDT 
[JSC] Optimize bound function calls
Comment 1 Yusuke Suzuki 2021-04-27 20:47:41 PDT 
Created attachment 427233 [details]
Patch
Comment 2 Yusuke Suzuki 2021-04-30 22:34:13 PDT 
Created attachment 427489 [details]
Patch
Comment 3 Yusuke Suzuki 2021-05-01 00:31:36 PDT 
Created attachment 427491 [details]
Patch
Comment 4 Yusuke Suzuki 2021-05-01 00:40:03 PDT 
Created attachment 427492 [details]
Patch
Comment 5 Yusuke Suzuki 2021-05-01 01:45:07 PDT 
Created attachment 427493 [details]
Patch
Comment 6 Yusuke Suzuki 2021-05-01 03:20:34 PDT 
Created attachment 427494 [details]
Patch
Comment 7 Yusuke Suzuki 2021-05-01 12:03:21 PDT 
Created attachment 427509 [details]
Patch
Comment 8 Yusuke Suzuki 2021-05-01 20:46:56 PDT 
Created attachment 427517 [details]
Patch
Comment 9 Mark Lam 2021-05-01 22:02:57 PDT 
Comment on attachment 427517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427517&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:764
> +        RegisterID* emitCreateArgumentsButterflyExcludingThis(RegisterID* dst, RegisterID* count);

Did you mean "target" instead of "count"?

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1939
> +    return generator.emitCreateArgumentsButterflyExcludingThis(generator.finalDestination(dst), additionalCount.get());

Is the 2nd argument supposed to be "additionalCount"?  This doesn't match the `@createArgumentsButterfly(this);` in FunctionPrototype.js.
Comment 10 Radar WebKit Bug Importer 2021-05-04 20:48:15 PDT 
<rdar://problem/77539823>
Comment 11 Yusuke Suzuki 2021-05-10 01:29:40 PDT 
Comment on attachment 427517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427517&action=review

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:764
>> +        RegisterID* emitCreateArgumentsButterflyExcludingThis(RegisterID* dst, RegisterID* count);
> 
> Did you mean "target" instead of "count"?

Changed to target. Yeah, "count" is the one from the old patch.

>> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1939
>> +    return generator.emitCreateArgumentsButterflyExcludingThis(generator.finalDestination(dst), additionalCount.get());
> 
> Is the 2nd argument supposed to be "additionalCount"?  This doesn't match the `@createArgumentsButterfly(this);` in FunctionPrototype.js.

Changed to target.
Comment 12 Yusuke Suzuki 2021-05-10 03:05:41 PDT 
Created attachment 428162 [details]
Patch
Comment 13 Yusuke Suzuki 2021-05-10 03:12:47 PDT 
Created attachment 428163 [details]
Patch
Comment 14 Yusuke Suzuki 2023-02-14 17:49:24 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10116
Comment 15 EWS 2023-02-15 01:30:58 PST 
Committed 260303@main (d99a52c87599): <https://commits.webkit.org/260303@main>

Reviewed commits have been landed. Closing PR #10116 and removing active labels.