Bug 225124 – Move ExceptionExpectation into its own .h file.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Mark Lam]

Created attachment 427198 [details]
proposed patch.

[Mark Lam]

Created attachment 427200 [details]
proposed patch.

[Mark Lam]

Created attachment 427201 [details]
proposed patch.

[Mark Lam]

Created attachment 427202 [details]
proposed patch.

[Robin Morisset]

Comment on attachment 427202 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427202&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Move ExceptionExpectation into its own .h file.

What is the goal of this?

> Source/JavaScriptCore/runtime/ExceptionHelpers.h:-39
> -enum class ExceptionExpectation {

Should we not #include "ExceptionExpectation" if it is used in this file?

[Mark Lam]

Comment on attachment 427202 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427202&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        Move ExceptionExpectation into its own .h file.
> 
> What is the goal of this?

It belongs in its own file instead of some other header file.  I was previously lazy and just stashed it in ExceptionHelpers.h.  Just making it right now.

>> Source/JavaScriptCore/runtime/ExceptionHelpers.h:-39
>> -enum class ExceptionExpectation {
> 
> Should we not #include "ExceptionExpectation" if it is used in this file?

It's not used in this file.

[Robin Morisset]

Comment on attachment 427202 [details]
proposed patch.

r=me

[Mark Lam]

Oops, my uploaded patch was missing this bit:

@@ -463,9 +463,10 @@ bool JSGenericTypedArrayView<Adaptor>::g
         return false;
 
     JSValue value;
-    if constexpr (Adaptor::canConvertToJSQuickly)
+    if constexpr (Adaptor::canConvertToJSQuickly) {
+        UNUSED_VARIABLE(scope);
         value = thisObject->getIndexQuickly(propertyName);
-    else {
+    } else {
         auto nativeValue = thisObject->getIndexQuicklyAsNativeValue(propertyName);
         value = Adaptor::toJSValue(globalObject, nativeValue);
         RETURN_IF_EXCEPTION(scope, false);

Talked to Robin offline, and he ok'ed me to include it for landing.

[Mark Lam]

Thanks for the review.  Landed in r276676: <http://trac.webkit.org/r276676>.

[Radar WebKit Bug Importer]

<rdar://problem/77235155>