Bug 22512 – Add a test to check for crashes in attaching an event to a created document.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[David Levin]

Need to add the test.

[David Levin]

Created attachment 25521 [details]
A patch to add the test.

[Eric Seidel (no email)]

Comment on attachment 25521 [details]
A patch to add the test.

This is an interesting combination of the old single-file .html style tests, and the new .js tests which use the fast/js/resources .js files and a TEMPLATE.html file. :)  Sadly none of this is very well documented, but what I think in an ideal world what you would have wanted to do was to add a fast/events/resources/create-document-crash-on-attach-event.js file with just the <script> section of your test, and then run make-js-test-wrappers to generate the corresponding .html file from the template (which likely already exists as fast/events/resources/TEMPLATE.html).  make-js-test-wrappers also automatically makes sure your .js file ends with var successfulllyParsed = true; etc.

Also, I think it's a bad idea to check for document.implementation and document.implementation.createDocument and allow the test to "pass" (or at least not do anything) if they're not found.

Do you have any information as to when this last crashed?  Was this only ever a crash for Chromium?

[David Levin]

Created attachment 25525 [details]
Addressed the comments by Eric.

The crash only happened in Chromium.

[Eric Seidel (no email)]

Comment on attachment 25525 [details]
Addressed the comments by Eric.

Looks fine.

[Pam Greene (IRC:pamg)]

Landed in r39159.