Bug 225113 - StructureStubInfo and PolymorphicAccess should account for their non-GC memory
Summary: StructureStubInfo and PolymorphicAccess should account for their non-GC memory
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on: 225930
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-27 11:05 PDT by Keith Miller
Modified: 2021-05-18 12:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2021-04-27 11:10 PDT, Keith Miller 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.61 KB, patch)
2021-04-27 11:20 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (7.41 KB, patch)
2021-04-27 12:04 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2021-04-27 11:05:18 PDT 
StructureStubInfo and PolyMorphicAccess should account for their non-GC memory
Comment 1 Keith Miller 2021-04-27 11:10:27 PDT 
Created attachment 427172 [details]
Patch
Comment 2 Keith Miller 2021-04-27 11:20:48 PDT 
Created attachment 427175 [details]
Patch
Comment 3 Mark Lam 2021-04-27 11:46:41 PDT 
Comment on attachment 427175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427175&action=review

r=me

> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:389
> +        size += sizeof(WatchpointsOnStructureStubInfo);

m_watchpoints has a Bag of stuff.  Do we need to add that size?
Comment 4 Keith Miller 2021-04-27 11:55:20 PDT 
Comment on attachment 427175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427175&action=review

>> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:389
>> +        size += sizeof(WatchpointsOnStructureStubInfo);
> 
> m_watchpoints has a Bag of stuff.  Do we need to add that size?

Yeah, for some reason I thought the watchpoints were owned by the code block but that doesn't make sense since they are not references or pointers in the Bag.
Comment 5 Keith Miller 2021-04-27 12:04:46 PDT 
Created attachment 427179 [details]
Patch for landing
Comment 6 EWS 2021-04-27 12:49:52 PDT 
Committed r276655 (237082@main): <https://commits.webkit.org/237082@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427179 [details].
Comment 7 Radar WebKit Bug Importer 2021-04-27 12:50:20 PDT 
<rdar://problem/77224968>
Comment 8 WebKit Commit Bot 2021-05-18 12:44:27 PDT 
Re-opened since this is blocked by bug 225930