Bug 225071 - [ Win ] 4 http/tests/security/contentSecurityPolicy/ tests are failing
Summary: [ Win ] 4 http/tests/security/contentSecurityPolicy/ tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Gambrell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-26 13:21 PDT by Truitt Savell
Modified: 2021-04-28 13:03 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2021-04-27 10:52 PDT, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Patch (3.97 KB, patch)
2021-04-27 14:59 PDT, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Patch (3.07 KB, patch)
2021-04-28 10:20 PDT, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2021-04-26 13:21:48 PDT 
http/tests/security/contentSecurityPolicy/audio-redirect-allowed.html [ Failure ]
  http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html [ Failure ]
  http/tests/security/contentSecurityPolicy/video-redirect-allowed.html [ Failure ]
  http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html [ Failure ]

These 4 tests are failing on windows, they all have the same diff which isn't very descriptive about that is really failing. 

history:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Faudio-redirect-allowed.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Faudio-redirect-allowed2.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fvideo-redirect-allowed.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fvideo-redirect-allowed2.html&platform=win

Diff:
--- /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/contentSecurityPolicy/audio-redirect-allowed-expected.txt
+++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/contentSecurityPolicy/audio-redirect-allowed-actual.txt
@@ -1,2 +1,2 @@
-ALERT: PASS
+ALERT: FAIL
Comment 1 Radar WebKit Bug Importer 2021-04-26 13:22:35 PDT 
<rdar://problem/77172923>
Comment 2 Truitt Savell 2021-04-26 13:24:51 PDT 
This could be related to the move from Python2 to Python3. these tests were last updated in https://trac.webkit.org/changeset/272981/webkit
Comment 3 Jonathan Bedard 2021-04-26 15:52:40 PDT 
Definitely fallout from the PHP to Python migration
Comment 4 Chris Gambrell 2021-04-27 10:52:46 PDT 
Created attachment 427167 [details]
Patch
Comment 5 Chris Gambrell 2021-04-27 10:54:38 PDT 
Comment on attachment 427167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427167&action=review

> LayoutTests/http/tests/resources/redirect.py:-16
> -query = {}

Changed the getting the query to the same way the other converted files are using.
Comment 6 Chris Gambrell 2021-04-27 14:59:44 PDT 
Created attachment 427199 [details]
Patch
Comment 7 Jonathan Bedard 2021-04-28 10:05:19 PDT 
Comment on attachment 427199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427199&action=review

> LayoutTests/http/tests/security/canvas-remote-read-data-url-image-redirect.html:68
> +image.src = "http://localhost:8000/resources/redirect.py?url=data:image/png%3bbase64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAADElEQVR42mP4%2F58BAAT%2FAf9jgNErAAAAAElFTkSuQmCC";

Is this bit actually needed with your redirect changes?
Comment 8 Chris Gambrell 2021-04-28 10:20:51 PDT 
Created attachment 427277 [details]
Patch
Comment 9 EWS 2021-04-28 13:03:43 PDT 
Committed r276731 (237132@main): <https://commits.webkit.org/237132@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427277 [details].