Bug 225071 – [ Win ] 4 http/tests/security/contentSecurityPolicy/ tests are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Truitt Savell]

http/tests/security/contentSecurityPolicy/audio-redirect-allowed.html [ Failure ]
  http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html [ Failure ]
  http/tests/security/contentSecurityPolicy/video-redirect-allowed.html [ Failure ]
  http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html [ Failure ]

These 4 tests are failing on windows, they all have the same diff which isn't very descriptive about that is really failing. 

history:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Faudio-redirect-allowed.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Faudio-redirect-allowed2.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fvideo-redirect-allowed.html&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fvideo-redirect-allowed2.html&platform=win

Diff:
--- /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/contentSecurityPolicy/audio-redirect-allowed-expected.txt
+++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/contentSecurityPolicy/audio-redirect-allowed-actual.txt
@@ -1,2 +1,2 @@
-ALERT: PASS
+ALERT: FAIL

[Radar WebKit Bug Importer]

<rdar://problem/77172923>

[Truitt Savell]

This could be related to the move from Python2 to Python3. these tests were last updated in https://trac.webkit.org/changeset/272981/webkit

[Jonathan Bedard]

Definitely fallout from the PHP to Python migration

[Chris Gambrell]

Created attachment 427167 [details]
Patch

[Chris Gambrell]

Comment on attachment 427167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427167&action=review

> LayoutTests/http/tests/resources/redirect.py:-16
> -query = {}

Changed the getting the query to the same way the other converted files are using.

[Chris Gambrell]

Created attachment 427199 [details]
Patch

[Jonathan Bedard]

Comment on attachment 427199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427199&action=review

> LayoutTests/http/tests/security/canvas-remote-read-data-url-image-redirect.html:68
> +image.src = "http://localhost:8000/resources/redirect.py?url=data:image/png%3bbase64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAADElEQVR42mP4%2F58BAAT%2FAf9jgNErAAAAAElFTkSuQmCC";

Is this bit actually needed with your redirect changes?

[Chris Gambrell]

Created attachment 427277 [details]
Patch

[EWS]

Committed r276731 (237132@main): <https://commits.webkit.org/237132@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427277 [details].