Bug 225068 - CodeBlock should do a better job accounting for extra memory it allocates.
Summary: CodeBlock should do a better job accounting for extra memory it allocates.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-26 12:15 PDT by Keith Miller
Modified: 2021-04-26 13:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.93 KB, patch)
2021-04-26 12:21 PDT, Keith Miller 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.91 KB, patch)
2021-04-26 12:27 PDT, Keith Miller 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.96 KB, patch)
2021-04-26 12:35 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (5.96 KB, patch)
2021-04-26 12:36 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2021-04-26 12:15:10 PDT 
CodeBlock should do a better job accounting for extra memory it allocates.
Comment 1 Keith Miller 2021-04-26 12:21:04 PDT 
Created attachment 427077 [details]
Patch
Comment 2 Mark Lam 2021-04-26 12:25:22 PDT 
Comment on attachment 427077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427077&action=review

r=me.  Looks like you have EWS issue.  Please fix.

> Source/WTF/ChangeLog:8
> +        Small convienience function to help compute the memory used by a Bag for JS CG

/convienience/convenience/
Comment 3 Keith Miller 2021-04-26 12:27:50 PDT 
Created attachment 427079 [details]
Patch for landing
Comment 4 Keith Miller 2021-04-26 12:28:35 PDT 
(In reply to Mark Lam from comment #2)
> Comment on attachment 427077 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427077&action=review
> 
> r=me.  Looks like you have EWS issue.  Please fix.

Will do! thanks!
Comment 5 Keith Miller 2021-04-26 12:35:37 PDT 
Created attachment 427080 [details]
Patch for landing
Comment 6 Keith Miller 2021-04-26 12:36:39 PDT 
Created attachment 427081 [details]
Patch for landing
Comment 7 EWS 2021-04-26 13:22:44 PDT 
Committed r276610 (237039@main): <https://commits.webkit.org/237039@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427081 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-26 13:23:18 PDT 
<rdar://problem/77172976>