WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
225067
Consistently include headers with <Framework/Header.h>
https://bugs.webkit.org/show_bug.cgi?id=225067
Summary
Consistently include headers with <Framework/Header.h>
Alex Christensen
Reported
2021-04-26 12:09:53 PDT
Consistently include headers with <Framework/Header.h>
Attachments
Patch
(42.22 KB, patch)
2021-04-26 12:12 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(40.47 KB, patch)
2021-04-26 16:45 PDT
,
Alex Christensen
ap
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2021-04-26 12:12:16 PDT
Created
attachment 427074
[details]
Patch
Alexey Proskuryakov
Comment 2
2021-04-26 14:17:51 PDT
Comment on
attachment 427074
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=427074&action=review
> Source/WebCore/platform/ios/WebItemProviderPasteboard.h:26 > -#import <WebCore/AbstractPasteboard.h> > +#import "AbstractPasteboard.h"
WebItemProviderPasteboard.h is a private header, so it needs to use framework style includes for WebCore headers. I didn't check the rest of the patch, please check it for other instances of this.
Alex Christensen
Comment 3
2021-04-26 16:45:03 PDT
Created
attachment 427104
[details]
Patch
Alex Christensen
Comment 4
2021-04-26 17:04:56 PDT
r276621
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug