Bug 225067 - Consistently include headers with <Framework/Header.h>
Summary: Consistently include headers with <Framework/Header.h>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 12:09 PDT by Alex Christensen
Modified: 2021-04-26 17:04 PDT (History)
14 users (show)

See Also:

Attachments
Patch (42.22 KB, patch)
2021-04-26 12:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (40.47 KB, patch)
2021-04-26 16:45 PDT, Alex Christensen 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-04-26 12:09:53 PDT 
Consistently include headers with <Framework/Header.h>
Comment 1 Alex Christensen 2021-04-26 12:12:16 PDT 
Created attachment 427074 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-04-26 14:17:51 PDT 
Comment on attachment 427074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427074&action=review

> Source/WebCore/platform/ios/WebItemProviderPasteboard.h:26
> -#import <WebCore/AbstractPasteboard.h>
> +#import "AbstractPasteboard.h"

WebItemProviderPasteboard.h is a private header, so it needs to use framework style includes for WebCore headers.

I didn't check the rest of the patch, please check it for other instances of this.
Comment 3 Alex Christensen 2021-04-26 16:45:03 PDT 
Created attachment 427104 [details]
Patch
Comment 4 Alex Christensen 2021-04-26 17:04:56 PDT 
r276621