RESOLVED FIXED 225054
[iOS] Coalesce adjacent selection geometries when rendering individual selection quads 
https://bugs.webkit.org/show_bug.cgi?id=225054
Summary [iOS] Coalesce adjacent selection geometries when rendering individual select...
Wenson Hsieh
Reported 2021-04-26 09:03:48 PDT
.
Attachments
For EWS (15.40 KB, patch)
2021-04-27 08:32 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
For EWS (15.45 KB, patch)
2021-04-27 08:49 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Renaming (15.39 KB, patch)
2021-04-28 14:24 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-04-27 08:32:47 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-04-27 08:49:02 PDT
Created attachment 427153 [details] For EWS
Tim Horton
Comment 3 2021-04-28 13:32:14 PDT
Comment on attachment 427153 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=427153&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1349 > +static Optional<SimpleRange> canonicalizeForImageOverlay(const SimpleRange& range) Can this be more specific than "canonicalize" which pretty much means nothing?
Wenson Hsieh
Comment 4 2021-04-28 13:33:00 PDT
Comment on attachment 427153 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=427153&action=review >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1349 >> +static Optional<SimpleRange> canonicalizeForImageOverlay(const SimpleRange& range) > > Can this be more specific than "canonicalize" which pretty much means nothing? Good point. How about "expandForImageOverlay"?
Wenson Hsieh
Comment 5 2021-04-28 14:24:19 PDT
Created attachment 427293 [details] Renaming
EWS
Comment 6 2021-04-28 18:36:41 PDT
Committed r276746 (237146@main): <https://commits.webkit.org/237146@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427293 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-28 18:37:14 PDT
<rdar://problem/77296813>
Note You need to log in before you can comment on or make changes to this bug.