Bug 225048 - Refcount Style::Resolver
Summary: Refcount Style::Resolver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-26 02:54 PDT by Antti Koivisto
Modified: 2021-04-26 06:19 PDT (History)
10 users (show)

See Also:

Attachments
patch (11.72 KB, patch)
2021-04-26 02:55 PDT, Antti Koivisto 		rniwa: review+
Details | Formatted Diff | Diff
patch (12.18 KB, patch)
2021-04-26 04:23 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-04-26 02:54:07 PDT 
For safety, and to allow more sharing in the future.
Comment 1 Antti Koivisto 2021-04-26 02:55:51 PDT 
Created attachment 427032 [details]
patch
Comment 2 Ryosuke Niwa 2021-04-26 03:02:05 PDT 
Comment on attachment 427032 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427032&action=review

> Source/WebCore/style/StyleResolver.h:83
> +class Resolver : public RefCounted<Resolver> {
>  public:

Should we iso-heap this?

> Source/WebCore/style/StyleScope.h:180
>      HashSet<const Element*> m_elementsInHeadWithPendingSheets;
>      HashSet<const Element*> m_elementsInBodyWithPendingSheets;

Yikes. We should use WeakHashSet for these!

> Source/WebCore/style/StyleTreeResolver.h:73
>          Scope* enclosingScope { nullptr };

Should this be RefPtr<Scope> as well?
Comment 3 Antti Koivisto 2021-04-26 04:23:58 PDT 
Created attachment 427035 [details]
patch
Comment 4 EWS 2021-04-26 06:18:02 PDT 
Committed r276588 (237024@main): <https://commits.webkit.org/237024@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427035 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-26 06:19:16 PDT 
<rdar://problem/77150042>