Bug 225045 – [ews] Add new builder WPE-Build-Non-Unified-EWS

• Status: NEW
• Component: WPE WebKit

[Diego Pino]

[ews] Add new builder WPE-Build-Non-Unified-EWS

[Diego Pino]

Created attachment 427024 [details]
Patch

[Aakash Jain]

Comment on attachment 427024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427024&action=review

> Tools/ChangeLog:8
> +        This new builder will build WPE with Unified builds disabled. That

Where is the unified build disabled in this patch? If that setting is done on the bots, it would be better if the setting could be made in the configuration here, so that we don't end up in a situation where a newly configured bot misses that setting, and keep doing unified builds without anyone noticing.

> Tools/CISupport/ews-app/ews/views/statusbubble.py:46
> +    ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'mac-AS-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wpe-noun', 'wincairo', 'win',

noun seems weird. maybe 'wpe-non-unified' might be better.

> Tools/CISupport/ews-build/config.json:606
> +      "name": "WPE-Build-Non-Unified-EWS",

Would be better to name: "WPE-Non-Unified-Build-EWS"

[Aakash Jain]

Also, please mention the motivation for this EWS.

[Diego Pino]

Created attachment 427037 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 427037 [details]
Patch

I don’t think that we have any agreement to keep this configuration building. Please reach consensus on webkit-dev before imposing this new requirement on WebKit developers.

[Diego Pino]

Created attachment 449776 [details]
Patch

[Diego Pino]

Created attachment 449785 [details]
Patch