Bug 225045 - [ews] Add new builder WPE-Build-Non-Unified-EWS
Summary: [ews] Add new builder WPE-Build-Non-Unified-EWS
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-25 23:09 PDT by Diego Pino
Modified: 2021-05-05 00:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.92 KB, patch)
2021-04-25 23:16 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (4.49 KB, patch)
2021-04-26 06:20 PDT, Diego Pino
ap: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-04-25 23:09:21 PDT
[ews] Add new builder WPE-Build-Non-Unified-EWS
Comment 1 Diego Pino 2021-04-25 23:16:11 PDT
Created attachment 427024 [details]
Patch
Comment 2 Aakash Jain 2021-04-26 05:22:04 PDT
Comment on attachment 427024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427024&action=review

> Tools/ChangeLog:8
> +        This new builder will build WPE with Unified builds disabled. That

Where is the unified build disabled in this patch? If that setting is done on the bots, it would be better if the setting could be made in the configuration here, so that we don't end up in a situation where a newly configured bot misses that setting, and keep doing unified builds without anyone noticing.

> Tools/CISupport/ews-app/ews/views/statusbubble.py:46
> +    ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'mac-AS-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wpe-noun', 'wincairo', 'win',

noun seems weird. maybe 'wpe-non-unified' might be better.

> Tools/CISupport/ews-build/config.json:606
> +      "name": "WPE-Build-Non-Unified-EWS",

Would be better to name: "WPE-Non-Unified-Build-EWS"
Comment 3 Aakash Jain 2021-04-26 05:22:58 PDT
Also, please mention the motivation for this EWS.
Comment 4 Diego Pino 2021-04-26 06:20:08 PDT
Created attachment 427037 [details]
Patch
Comment 5 Alexey Proskuryakov 2021-04-26 07:20:21 PDT
Comment on attachment 427037 [details]
Patch

I don’t think that we have any agreement to keep this configuration building. Please reach consensus on webkit-dev before imposing this new requirement on WebKit developers.