Bug 225031 - [GPUP][iOS] Silent video playback can interrupt system audio
Summary: [GPUP][iOS] Silent video playback can interrupt system audio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-25 09:22 PDT by Jer Noble
Modified: 2021-04-25 13:38 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2021-04-25 09:30 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (6.19 KB, patch)
2021-04-25 10:19 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-04-25 09:22:25 PDT 
[GPUP][iOS] Silent video playback can interrupt system audio
Comment 1 Jer Noble 2021-04-25 09:23:00 PDT 
<rdar://76652073>
Comment 2 Jer Noble 2021-04-25 09:30:35 PDT 
Created attachment 427003 [details]
Patch
Comment 3 Jer Noble 2021-04-25 10:19:05 PDT 
Created attachment 427004 [details]
Patch for landing
Comment 4 EWS 2021-04-25 13:32:32 PDT 
Committed r276570 (237006@main): <https://commits.webkit.org/237006@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427004 [details].
Comment 5 Darin Adler 2021-04-25 13:38:43 PDT 
Comment on attachment 427004 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=427004&action=review

> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:74
> +    AudioSession::CategoryType category = AudioSession::None;
> +    RouteSharingPolicy policy = RouteSharingPolicy::Default;

Next time we touch this, we can just use auto here to take advantage of the fact that the enumeration values already carry their type.