RESOLVED FIXED 225030
Bump CeilingOnPageSize to 16KB on MIPS 
https://bugs.webkit.org/show_bug.cgi?id=225030
Summary Bump CeilingOnPageSize to 16KB on MIPS
Angelos Oikonomopoulos
Reported 2021-04-25 02:13:17 PDT
Bump CeilingOnPageSize to 16KB on MIPS
Attachments
Patch (1.51 KB, patch)
2021-04-25 02:15 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2021-04-25 02:15:01 PDT
Created attachment 426998 [details] Patch
Michael Catanzaro
Comment 2 2021-04-25 05:45:09 PDT
Comment on attachment 426998 [details] Patch MIPS64 uses a smaller page size than original MIPS? OK.
Angelos Oikonomopoulos
Comment 3 2021-04-26 01:38:47 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 426998 [details] > Patch > > MIPS64 uses a smaller page size than original MIPS? OK. AFAIK the choice of page size is up to the kernel -- for non-embedded mips64 systems, some distributions choose a 16KB. Not sure what counts as "original MIPS", but I expect most embedded MIPS systems prefer 4KB pages (which is the previous value for CeilingOnPageSize for MIPS).
EWS
Comment 4 2021-04-26 02:04:10 PDT
Committed r276583 (237019@main): <https://commits.webkit.org/237019@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426998 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-26 02:05:16 PDT
<rdar://problem/77143561>
Alberto Garcia
Comment 6 2021-05-15 14:10:07 PDT
(In reply to Angelos Oikonomopoulos from comment #3) > > MIPS64 uses a smaller page size than original MIPS? OK. > > AFAIK the choice of page size is up to the kernel -- for non-embedded mips64 > systems, some distributions choose a 16KB. Not sure what counts as "original > MIPS", but I expect most embedded MIPS systems prefer 4KB pages (which is > the previous value for CeilingOnPageSize for MIPS). FWIW in Debian we have a downstream patch to use 16KB pages in MIPS64, it seems that Loongson CPUs don't support 4KB pages.
Angelos Oikonomopoulos
Comment 7 2021-05-17 06:59:57 PDT
(In reply to Alberto Garcia from comment #6) [...] > FWIW in Debian we have a downstream patch to use 16KB pages in MIPS64, > it seems that Loongson CPUs don't support 4KB pages. Good to know, thanks!
Note You need to log in before you can comment on or make changes to this bug.