Bug 225028 - Deploy Ref/RefPtr in DeleteSelectionCommand
Summary: Deploy Ref/RefPtr in DeleteSelectionCommand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-24 19:18 PDT by Ryosuke Niwa
Modified: 2021-04-24 23:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (29.80 KB, patch)
2021-04-24 19:24 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (29.99 KB, patch)
2021-04-24 19:34 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-04-24 19:18:35 PDT 
We should use more smart pointers in DeleteSelectionCommand.
Comment 1 Ryosuke Niwa 2021-04-24 19:24:32 PDT 
Created attachment 426995 [details]
Patch
Comment 2 Wenson Hsieh 2021-04-24 19:30:19 PDT 
Comment on attachment 426995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426995&action=review

r=mews

> Source/WebCore/editing/DeleteSelectionCommand.cpp:1044
> +            Text& textNode = downcast<Text>(*endNode);

Nit - auto& here.
Comment 3 Ryosuke Niwa 2021-04-24 19:34:54 PDT 
Created attachment 426996 [details]
Patch for landing
Comment 4 Ryosuke Niwa 2021-04-24 19:35:07 PDT 
Comment on attachment 426996 [details]
Patch for landing

Wait for EWS.
Comment 5 Ryosuke Niwa 2021-04-24 23:00:03 PDT 
Comment on attachment 426996 [details]
Patch for landing

Clearing flags on attachment: 426996

Committed r276563 (236999@main): <https://commits.webkit.org/236999@main>
Comment 6 Ryosuke Niwa 2021-04-24 23:00:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2021-04-24 23:01:19 PDT 
<rdar://problem/77114154>