Bug 22502 - [Windows] WebCoreGenerated Project Should Support Arguments
Summary: [Windows] WebCoreGenerated Project Should Support Arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Windows XP
: P3 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 16:21 PST by Brent Fulgham
Modified: 2009-07-17 12:42 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-11-25 16:21:13 PST
The Problem:
=============
The WebCoreGenerated Visual Studio project uses the build-generated-files.sh script to convert various IDL files into C++ implementations.  The shell script is hard coded with the following FEATURE_DEFINE values:

ENABLE_DATABASE ENABLE_DOM_STORAGE ENABLE_ICONDATABASE ENABLEOFFLINE_WEB_APPLICATIONS ENABLE_PATH ENABLE_SVG ENABLE_SVG_ANIMATION ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_AS_IMAGE ENABLE_SVG_USE ENABLE_WORKERS ENABLE_VIDEO

When targeting something like the Cairo variant of the Windows build, we need to exclude the ENABLE_VIDEO to avoid pulling the QuickTime libraries, since they may not be redistributed.

Proposed Solution
============
Modify the build-generated-files.sh so that it takes the FEATURE_DEFINES as an argument so that different configurations in Visual Studio could populate this with different values.