Bug 225019 - Improve parsing and computed style of the rotate CSS property
Summary: Improve parsing and computed style of the rotate CSS property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-24 09:10 PDT by Antoine Quint
Modified: 2021-04-26 06:14 PDT (History)
11 users (show)

See Also:

Attachments
Patch (26.90 KB, patch)
2021-04-24 09:18 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-04-24 09:10:13 PDT 
Improve parsing and computed style of the rotate CSS property
Comment 1 Antoine Quint 2021-04-24 09:18:42 PDT 
Created attachment 426983 [details]
Patch
Comment 2 EWS Watchlist 2021-04-24 09:19:38 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Dean Jackson 2021-04-24 11:15:25 PDT 
Comment on attachment 426983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426983&action=review

> LayoutTests/imported/w3c/ChangeLog:14
> +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
> +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:

Isn't this the wrong place to make this change? How will it get submitted back to WPT?
Comment 4 Antoine Quint 2021-04-24 11:16:23 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 426983 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426983&action=review
> 
> > LayoutTests/imported/w3c/ChangeLog:14
> > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
> > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:
> 
> Isn't this the wrong place to make this change? How will it get submitted
> back to WPT?

I'll make a WPT PR from this patch once it lands.
Comment 5 EWS 2021-04-24 12:36:35 PDT 
Committed r276554 (236994@main): <https://commits.webkit.org/236994@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426983 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-24 12:37:16 PDT 
<rdar://problem/77108692>
Comment 7 Antoine Quint 2021-04-26 06:14:55 PDT 
(In reply to Antoine Quint from comment #4)
> (In reply to Dean Jackson from comment #3)
> > Comment on attachment 426983 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=426983&action=review
> > 
> > > LayoutTests/imported/w3c/ChangeLog:14
> > > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
> > > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:
> > 
> > Isn't this the wrong place to make this change? How will it get submitted
> > back to WPT?
> 
> I'll make a WPT PR from this patch once it lands.

The PR is up at https://github.com/web-platform-tests/wpt/pull/28691.