Bug 225019 – Improve parsing and computed style of the rotate CSS property

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antoine Quint]

Improve parsing and computed style of the rotate CSS property

[Antoine Quint]

Created attachment 426983 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Dean Jackson]

Comment on attachment 426983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426983&action=review

> LayoutTests/imported/w3c/ChangeLog:14
> +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
> +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:

Isn't this the wrong place to make this change? How will it get submitted back to WPT?

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 426983 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426983&action=review
> 
> > LayoutTests/imported/w3c/ChangeLog:14
> > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
> > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:
> 
> Isn't this the wrong place to make this change? How will it get submitted
> back to WPT?

I'll make a WPT PR from this patch once it lands.

[EWS]

Committed r276554 (236994@main): <https://commits.webkit.org/236994@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426983 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77108692>

[Antoine Quint]

(In reply to Antoine Quint from comment #4)
> (In reply to Dean Jackson from comment #3)
> > Comment on attachment 426983 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=426983&action=review
> > 
> > > LayoutTests/imported/w3c/ChangeLog:14
> > > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt:
> > > +        * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html:
> > 
> > Isn't this the wrong place to make this change? How will it get submitted
> > back to WPT?
> 
> I'll make a WPT PR from this patch once it lands.

The PR is up at https://github.com/web-platform-tests/wpt/pull/28691.