WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
224996
[RenderTreeBuilder] Subtree moving should clear the floats on all the descendants
https://bugs.webkit.org/show_bug.cgi?id=224996
Summary
[RenderTreeBuilder] Subtree moving should clear the floats on all the descend...
zalan
Reported
2021-04-23 14:21:02 PDT
<
rdar://76837320
> and not only on the root of the move.
Attachments
Patch
(6.10 KB, patch)
2021-04-23 15:27 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
[fast-cq] Patch
(6.11 KB, patch)
2021-04-24 06:40 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2021-04-23 15:27:49 PDT
Created
attachment 426955
[details]
Patch
Antti Koivisto
Comment 2
2021-04-23 21:47:08 PDT
Comment on
attachment 426955
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=426955&action=review
> Source/WebCore/ChangeLog:9 > + While moving a subtre, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout).
We should really stop moving subtrees. Also spelling.
zalan
Comment 3
2021-04-24 06:37:31 PDT
(In reply to Antti Koivisto from
comment #2
)
> Comment on
attachment 426955
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=426955&action=review
> > > Source/WebCore/ChangeLog:9 > > + While moving a subtre, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout). > > We should really stop moving subtrees. Also spelling.
Yes and yes. I wonder what we'll come up with for LFC where the layout nodes (renderers) don't store layout states so moving subtrees is nothing but a simple re-parenting activity, while we have to run invalidation on the formatting state objects.
zalan
Comment 4
2021-04-24 06:40:07 PDT
Created
attachment 426979
[details]
[fast-cq] Patch
EWS
Comment 5
2021-04-24 06:42:13 PDT
Committed
r276549
(
236989@main
): <
https://commits.webkit.org/236989@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 426979
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug