Bug 224996 - [RenderTreeBuilder] Subtree moving should clear the floats on all the descendants
Summary: [RenderTreeBuilder] Subtree moving should clear the floats on all the descend...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-23 14:21 PDT by zalan
Modified: 2021-04-24 06:42 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.10 KB, patch)
2021-04-23 15:27 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (6.11 KB, patch)
2021-04-24 06:40 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-04-23 14:21:02 PDT
<rdar://76837320>

and not only on the root of the move.
Comment 1 zalan 2021-04-23 15:27:49 PDT
Created attachment 426955 [details]
Patch
Comment 2 Antti Koivisto 2021-04-23 21:47:08 PDT
Comment on attachment 426955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426955&action=review

> Source/WebCore/ChangeLog:9
> +        While moving a subtre, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout).

We should really stop moving subtrees. Also spelling.
Comment 3 zalan 2021-04-24 06:37:31 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 426955 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426955&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        While moving a subtre, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout).
> 
> We should really stop moving subtrees. Also spelling.
Yes and yes. I wonder what we'll come up with for LFC where the layout nodes (renderers) don't store layout states so moving subtrees is nothing but a simple re-parenting activity, while we have to run invalidation on the formatting state objects.
Comment 4 zalan 2021-04-24 06:40:07 PDT
Created attachment 426979 [details]
[fast-cq] Patch
Comment 5 EWS 2021-04-24 06:42:13 PDT
Committed r276549 (236989@main): <https://commits.webkit.org/236989@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426979 [details].