Bug 224991 – [Metal ANGLE] Temporarily remove AST validation even for debug builds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[John Cunningham]

[Metal ANGLE] Temporarily remove AST validation even for debug builds

[John Cunningham]

Created attachment 426937 [details]
Patch

[John Cunningham]

<rdar://problem/76299178>

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

Could you please provide a description in this bug of why this is being done, and how temporarily this is being removed?

[John Cunningham]

Sure thing. We are seeing significant slow downs inside of the validateAST calls on debug builds leading to test timeouts. 

There are a significant number of transform passes as a part of the GLSL AST -> MSL translation, and currently each pass is validating the AST. Theses were mainly in place during development of the translator, and the correct fix is to move the validation to the very end after all of the transformations happen. To unblock further testing, we'd like to land this stopgap to run all of the debug testing, until we land the more correct fix (hopefully within the next few days.)

[Kenneth Russell]

Comment on attachment 426937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426937&action=review

Thanks for the explanation. r+

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm:88
> +#if defined(ANGLE_ENABLE_ASSERTS) && 0

Please add some TODO here regarding moving this validation in the future so we don't forget it.

[John Cunningham]

Created attachment 426942 [details]
Patch

[Kenneth Russell]

Comment on attachment 426942 [details]
Patch

Thanks, still looks good. r+ again

[EWS]

Committed r276568 (237004@main): <https://commits.webkit.org/237004@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426942 [details].