Bug 224980 - REGRESSION (r271861): [iOS] Accessory bar navigation to elements outside the viewport fails
Summary: REGRESSION (r271861): [iOS] Accessory bar navigation to elements outside the ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
Keywords: InRadar
Depends on:
Reported: 2021-04-23 08:59 PDT by Aditya Keerthi
Modified: 2021-04-26 10:35 PDT (History)
4 users (show)

See Also:

Patch (3.69 KB, patch)
2021-04-23 09:09 PDT, Aditya Keerthi
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (3.69 KB, patch)
2021-04-26 09:07 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-04-23 08:59:48 PDT
Comment 1 Aditya Keerthi 2021-04-23 09:00:11 PDT
Comment 2 Aditya Keerthi 2021-04-23 09:09:13 PDT
Created attachment 426913 [details]
Comment 3 Wenson Hsieh 2021-04-26 08:58:49 PDT
Comment on attachment 426913 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=426913&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2569
> +    constexpr OptionSet<HitTestRequest::RequestType> hitType { HitTestRequest::ReadOnly, HitTestRequest::Active,  HitTestRequest::AllowChildFrameContent, HitTestRequest::DisallowUserAgentShadowContent, HitTestRequest::IgnoreClipping };

Nit - it looks like this adds an extra leading space before `HitTestRequest::AllowChildFrameContent`.
Comment 4 Aditya Keerthi 2021-04-26 09:07:55 PDT
Created attachment 427054 [details]
Patch for landing
Comment 5 EWS 2021-04-26 10:35:23 PDT
Committed r276598 (237033@main): <https://commits.webkit.org/237033@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427054 [details].