Bug 22498 - DRT transition pause tests need improvement
Summary: DRT transition pause tests need improvement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 14:28 PST by Dean Jackson
Modified: 2009-03-02 11:51 PST (History)
2 users (show)

See Also:


Attachments
cleans up tests (4.45 KB, patch)
2008-12-01 14:25 PST, Dean Jackson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2008-11-25 14:28:33 PST
re LayoutTests/transitions/transition-drt-api-delay.html and transition-shorthand-delay.html

Simon says:
shouldn't use red unless there is failure
make the boxes smaller, make them green, put in a bit more explanatory text
pref. links to bugs
but not too much text
also, the test should say if it only works in DRT
Comment 1 Pierre-Olivier Latour 2008-11-25 15:15:40 PST
Another issue is that the DRT pause API is not implemented on windows, so you need to update the skip file:
LayoutTests/platform/win/Skipped
Comment 2 Simon Fraser (smfr) 2008-11-30 19:51:11 PST
What's the bug for implementing the pause API on Windows?
Comment 3 Pierre-Olivier Latour 2008-12-01 11:25:00 PST
(In reply to comment #2)
> What's the bug for implementing the pause API on Windows?
> 

https://bugs.webkit.org/show_bug.cgi?id=22239
Comment 4 Dean Jackson 2008-12-01 14:25:40 PST
Created attachment 25637 [details]
cleans up tests

I left the -expected.txt files in the same dir. While the API is mac-only at the moment, there is nothing platform specific about the output.
Comment 5 Dean Jackson 2008-12-03 12:01:16 PST
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/win/Skipped
	M	LayoutTests/transitions/transition-drt-api-delay-expected.txt
	M	LayoutTests/transitions/transition-drt-api-delay.html
	M	LayoutTests/transitions/transition-shorthand-delay-expected.txt
	M	LayoutTests/transitions/transition-shorthand-delay.html
Committed r38957