WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22498
DRT transition pause tests need improvement
https://bugs.webkit.org/show_bug.cgi?id=22498
Summary
DRT transition pause tests need improvement
Dean Jackson
Reported
2008-11-25 14:28:33 PST
re LayoutTests/transitions/transition-drt-api-delay.html and transition-shorthand-delay.html Simon says: shouldn't use red unless there is failure make the boxes smaller, make them green, put in a bit more explanatory text pref. links to bugs but not too much text also, the test should say if it only works in DRT
Attachments
cleans up tests
(4.45 KB, patch)
2008-12-01 14:25 PST
,
Dean Jackson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pierre-Olivier Latour
Comment 1
2008-11-25 15:15:40 PST
Another issue is that the DRT pause API is not implemented on windows, so you need to update the skip file: LayoutTests/platform/win/Skipped
Simon Fraser (smfr)
Comment 2
2008-11-30 19:51:11 PST
What's the bug for implementing the pause API on Windows?
Pierre-Olivier Latour
Comment 3
2008-12-01 11:25:00 PST
(In reply to
comment #2
)
> What's the bug for implementing the pause API on Windows? >
https://bugs.webkit.org/show_bug.cgi?id=22239
Dean Jackson
Comment 4
2008-12-01 14:25:40 PST
Created
attachment 25637
[details]
cleans up tests I left the -expected.txt files in the same dir. While the API is mac-only at the moment, there is nothing platform specific about the output.
Dean Jackson
Comment 5
2008-12-03 12:01:16 PST
M LayoutTests/ChangeLog M LayoutTests/platform/win/Skipped M LayoutTests/transitions/transition-drt-api-delay-expected.txt M LayoutTests/transitions/transition-drt-api-delay.html M LayoutTests/transitions/transition-shorthand-delay-expected.txt M LayoutTests/transitions/transition-shorthand-delay.html Committed
r38957
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug