Bug 224976 - [GStreamer][EME] cbcs fixes
Summary: [GStreamer][EME] cbcs fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-23 07:47 PDT by Xabier Rodríguez Calvar
Modified: 2021-04-24 15:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2021-04-23 07:50 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (2.99 KB, patch)
2021-04-23 08:57 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2021-04-23 07:47:11 PDT 
[GStreamer][EME] cbcs fixes
Comment 1 Xabier Rodríguez Calvar 2021-04-23 07:50:20 PDT 
Created attachment 426907 [details]
Patch
Comment 2 Philippe Normand 2021-04-23 07:58:22 PDT 
Comment on attachment 426907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426907&action=review

> Source/WebCore/ChangeLog:14
> +        cbcs buffers could not include the subsample_count, we conside 0

consider

> Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:247
> +    unsigned subSampleCount = 0;
> +    gst_structure_get_uint(protectionMeta->info, "subsample_count", &subSampleCount);

Shouldn't this be conditioned on the caps? subsample_count is irrelevant for CBCS but is relevant for the other system.
Comment 3 Xabier Rodríguez Calvar 2021-04-23 08:57:03 PDT 
Created attachment 426912 [details]
Patch
Comment 4 EWS 2021-04-23 09:31:40 PDT 
Committed r276500 (236959@main): <https://commits.webkit.org/236959@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426912 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-24 15:02:59 PDT 
<rdar://problem/77110028>