Bug 224934 – [css-flexbox] Table layout disregards overriding width

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Felipe Erias]

Several WPT tests fail because table layout does not follow the width that has been set by its flex parent.

[Felipe Erias]

Created attachment 426821 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 426821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review

> Source/WebCore/ChangeLog:18
> +        Give precedence to the element's overriding width if it has been set, instead of discarding it

Super nit: we normally start writing the comment just after the semicolon, so move part of this description to the above line.

> Source/WebCore/ChangeLog:20
> +        (WebCore::RenderTable::computePreferredLogicalWidths):

Ditto.

> Source/WebCore/rendering/AutoTableLayout.cpp:287
> +        if (tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive())

You can now write this in a single line like this:

else if (auto tableLogicalWidth = m_table->style().logicalWidth(); tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive())

[Sergio Villar Senin]

Comment on attachment 426821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt:24
> +width expected 0 but got 51

You'd have to modify the GTK's specific expectations for this test, otherwise they'll fail in mac platforms

[Felipe Erias]

Created attachment 426901 [details]
Patch

[Felipe Erias]

Thank you very much for your review! I have updated the patch as suggested.

[EWS]

Committed r276572 (237008@main): <https://commits.webkit.org/237008@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426901 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77127138>