Bug 224923 – Add discrete animation support for border-image-repeat

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Add discrete animation support for border-image-repeat

[Antoine Quint]

Created attachment 426793 [details]
Patch

[Antti Koivisto]

Comment on attachment 426793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426793&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:699
> +class BorderImageRepeatWrapper : public AnimationPropertyWrapperBase {

final?

> Source/WebCore/animation/CSSPropertyAnimation.cpp:732
> +    std::unique_ptr<AnimationPropertyWrapperBase> m_horizontalWrapper;
> +    std::unique_ptr<AnimationPropertyWrapperBase> m_verticalWrapper;

These could probably be just 

DiscretePropertyWrapper<NinePieceImageRule> m_horizontalWrapper;

instead of unique_ptr. Even with unique_ptr they could have the actual type instead of the base type.

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 426793 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426793&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:699
> > +class BorderImageRepeatWrapper : public AnimationPropertyWrapperBase {
> 
> final?
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:732
> > +    std::unique_ptr<AnimationPropertyWrapperBase> m_horizontalWrapper;
> > +    std::unique_ptr<AnimationPropertyWrapperBase> m_verticalWrapper;
> 
> These could probably be just 
> 
> DiscretePropertyWrapper<NinePieceImageRule> m_horizontalWrapper;
> 
> instead of unique_ptr. Even with unique_ptr they could have the actual type
> instead of the base type.

The reason I did use AnimationPropertyWrapperBase instead of DiscretePropertyWrapper<NinePieceImageRule> was so that I didn't have to change some of the virtual methods from private to protected on parent classes.

[Antoine Quint]

Created attachment 426844 [details]
Patch for landing

[EWS]

Committed r276465 (236925@main): <https://commits.webkit.org/236925@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426844 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77045712>