Bug 224921 - [GTK] Turn on editable <input type=date> and <input type=time> fields
Summary: [GTK] Turn on editable <input type=date> and <input type=time> fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 98936
  Show dependency tree / graph
 
Reported: 2021-04-22 02:01 PDT by Martin Robinson
Modified: 2021-04-22 11:10 PDT (History)
11 users (show)

See Also:

Attachments
Patch (30.03 KB, patch)
2021-04-22 06:26 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (23.18 KB, patch)
2021-04-22 06:27 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-04-22 02:01:19 PDT 
We can turn on this feature without actually implementing support for the date picker. This will enable the interior shadow DOM of these input elements allowing for proper input via the keyboard of dates and times. The reasoning for not implementing the date picker UI is that the code currently assumes that the date picker UI can be used without taking focus from the browser window. This isn't as straight-forward to implement in GTK.
Comment 1 Martin Robinson 2021-04-22 06:26:26 PDT 
Created attachment 426805 [details]
Patch
Comment 2 Martin Robinson 2021-04-22 06:27:54 PDT 
Created attachment 426806 [details]
Patch
Comment 3 EWS Watchlist 2021-04-22 06:29:08 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 EWS 2021-04-22 11:10:02 PDT 
Committed r276448 (236908@main): <https://commits.webkit.org/236908@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426806 [details].