Bug 224918 - [Win][WTR] eventSender.leapForward doesn't work as expected
Summary: [Win][WTR] eventSender.leapForward doesn't work as expected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 23:33 PDT by Fujii Hironori
Modified: 2021-04-22 16:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2021-04-21 23:40 PDT, Fujii Hironori
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.14 KB, patch)
2021-04-21 23:53 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-04-21 23:33:35 PDT
[Win][WTR] eventSender.leapForward doesn't work as expected

For example, fast/events/click-count.html is failing.
Comment 1 Fujii Hironori 2021-04-21 23:40:26 PDT
Created attachment 426779 [details]
Patch
Comment 2 Fujii Hironori 2021-04-21 23:53:02 PDT
Created attachment 426780 [details]
Patch
Comment 3 Fujii Hironori 2021-04-22 13:01:14 PDT
Comment on attachment 426780 [details]
Patch

Clearing flags on attachment: 426780

Committed r276455 (236915@main): <https://commits.webkit.org/236915@main>
Comment 4 Fujii Hironori 2021-04-22 13:01:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2021-04-22 15:59:30 PDT
<rdar://problem/77042720>
Comment 6 Darin Adler 2021-04-22 16:44:27 PDT
Comment on attachment 426780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426780&action=review

> Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp:154
> +    Sleep(milliseconds);

Actually waiting the specified length of time is *not* the concept of leapForward. Are you sure this will meet our needs for rapid testing?
Comment 7 Fujii Hironori 2021-04-22 16:55:04 PDT
Comment on attachment 426780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426780&action=review

>> Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp:154
>> +    Sleep(milliseconds);
> 
> Actually waiting the specified length of time is *not* the concept of leapForward. Are you sure this will meet our needs for rapid testing?

Yeah, it's somewhat sad. However, one one complains for DumpRenderTree for decades since r29992.