Bug 224914 - [RenderTreeBuilder] Multi-column spanners are not part of the enclosing multi-column renderer's subtree
Summary: [RenderTreeBuilder] Multi-column spanners are not part of the enclosing multi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 20:58 PDT by zalan
Modified: 2021-04-22 15:02 PDT (History)
9 users (show)

See Also:


Attachments
Patch (6.50 KB, patch)
2021-04-21 21:15 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.64 KB, patch)
2021-04-22 10:25 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-04-21 20:58:39 PDT
<rdar://76846946>
Comment 1 zalan 2021-04-21 21:15:05 PDT
Created attachment 426769 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-04-21 21:29:12 PDT
Comment on attachment 426769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426769&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:749
> +                    // This child is a spanner so it is not in the subtree of the multicolumn renderer (parented directly under the block flow). 

The parenthetical adds confusion. Write it as a new sentence.
Comment 3 zalan 2021-04-22 10:25:04 PDT
Created attachment 426826 [details]
Patch
Comment 4 EWS 2021-04-22 15:02:23 PDT
Committed r276464 (236924@main): <https://commits.webkit.org/236924@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426826 [details].