Bug 224904 - Sometimes appHighlights are not painted when created.
Summary: Sometimes appHighlights are not painted when created.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 16:27 PDT by Megan Gardner
Modified: 2021-04-23 00:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2021-04-21 16:29 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (4.96 KB, patch)
2021-04-22 01:21 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2021-04-22 02:01 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (4.94 KB, patch)
2021-04-22 11:02 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2021-04-22 12:31 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (5.00 KB, patch)
2021-04-22 20:06 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-04-21 16:27:05 PDT
Sometimes appHighlights are not painted when created.
Comment 1 Megan Gardner 2021-04-21 16:29:36 PDT
Created attachment 426752 [details]
Patch
Comment 2 Antti Koivisto 2021-04-21 21:28:51 PDT
Comment on attachment 426752 [details]
Patch

Please add a test.
Comment 3 Megan Gardner 2021-04-22 01:21:06 PDT
Created attachment 426789 [details]
Patch
Comment 4 Megan Gardner 2021-04-22 02:01:32 PDT
Created attachment 426791 [details]
Patch
Comment 5 Megan Gardner 2021-04-22 11:02:46 PDT
Created attachment 426829 [details]
Patch
Comment 6 Tim Horton 2021-04-22 11:19:28 PDT
Comment on attachment 426829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426829&action=review

You can just forward Antti's review.

> Source/WebCore/ChangeLog:7
> +

Somehow you lost the `New test: ...` line here

> Source/WebCore/ChangeLog:8
> +        In order for highlights to be painted correclty, we need to not use the new line layout code,

"correctly"
Comment 7 Megan Gardner 2021-04-22 12:31:22 PDT
Created attachment 426838 [details]
Patch
Comment 8 Megan Gardner 2021-04-22 20:06:11 PDT
Created attachment 426885 [details]
Patch for landing
Comment 9 EWS 2021-04-22 20:57:05 PDT
Committed r276484 (236943@main): <https://commits.webkit.org/236943@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426885 [details].
Comment 10 Megan Gardner 2021-04-23 00:09:56 PDT
rdar://76786408