Bug 224897 - Disable GPUProcess on shipping iOS
Summary: Disable GPUProcess on shipping iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 14:38 PDT by Chris Dumez
Modified: 2021-04-24 15:02 PDT (History)
16 users (show)

See Also:

Attachments
Patch (23.92 KB, patch)
2021-04-22 09:07 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.92 KB, patch)
2021-04-22 09:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.13 KB, patch)
2021-04-22 11:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.87 KB, patch)
2021-04-22 17:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2021-04-22 18:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.92 KB, patch)
2021-04-22 18:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2021-04-22 18:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2021-04-22 18:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-21 14:38:28 PDT 
Disable GPUProcess on shipping iOS due to missing platform support.
Comment 1 Chris Dumez 2021-04-22 09:07:49 PDT 
Created attachment 426818 [details]
Patch
Comment 2 Chris Dumez 2021-04-22 09:11:05 PDT 
Created attachment 426820 [details]
Patch
Comment 3 Tim Horton 2021-04-22 11:13:54 PDT 
Comment on attachment 426820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426820&action=review

Why build-time instead of run-time?

> Source/WTF/wtf/PlatformEnableCocoa.h:223
> +#if PLATFORM(MAC) \

I think you still want the !defined() check
Comment 4 Chris Dumez 2021-04-22 11:30:48 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 426820 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426820&action=review
> 
> Why build-time instead of run-time?

I hesitated. Seems it is not worth building the code on a platform that doesn't support it. Also, if I disabled it by default on a specific platform, it wouldn't prevent someones from explicitly enabling it back in the experimental features.

> 
> > Source/WTF/wtf/PlatformEnableCocoa.h:223
> > +#if PLATFORM(MAC) \
> 
> I think you still want the !defined() check

oh OK.
Comment 5 Chris Dumez 2021-04-22 11:33:13 PDT 
Created attachment 426832 [details]
Patch
Comment 6 Chris Dumez 2021-04-22 17:14:30 PDT 
Created attachment 426871 [details]
Patch
Comment 7 Chris Dumez 2021-04-22 18:14:42 PDT 
Created attachment 426878 [details]
Patch
Comment 8 Chris Dumez 2021-04-22 18:19:47 PDT 
Created attachment 426879 [details]
Patch
Comment 9 Chris Dumez 2021-04-22 18:25:00 PDT 
Created attachment 426880 [details]
Patch
Comment 10 Chris Dumez 2021-04-22 18:28:02 PDT 
Created attachment 426881 [details]
Patch
Comment 11 EWS 2021-04-23 10:44:11 PDT 
Committed r276506 (236963@main): <https://commits.webkit.org/236963@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426881 [details].
Comment 12 Radar WebKit Bug Importer 2021-04-24 15:02:36 PDT 
<rdar://problem/77110021>