Bug 224883 - Introduce helper methods to map FloatQuads to and from content and root view coordinates
Summary: Introduce helper methods to map FloatQuads to and from content and root view ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 12:05 PDT by Wenson Hsieh
Modified: 2021-04-22 19:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2021-04-21 13:15 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Followup tweak (1.68 KB, patch)
2021-04-22 17:13 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-04-21 12:05:13 PDT 
.
Comment 1 Wenson Hsieh 2021-04-21 13:15:06 PDT 
Created attachment 426735 [details]
Patch
Comment 2 EWS 2021-04-21 16:06:57 PDT 
Committed r276397 (236872@main): <https://commits.webkit.org/236872@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426735 [details].
Comment 3 Darin Adler 2021-04-22 16:51:19 PDT 
Comment on attachment 426735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426735&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1076
> +            for (size_t i = 0; i < quads.size(); ++i)
> +                quads[i] = view->contentsToRootView(quads[i]);

range-based for loop here:

    for (auto& quad : quads)
        quad = ->contentsToRootView(quad);
Comment 4 Wenson Hsieh 2021-04-22 17:13:38 PDT 
Reopening to attach new patch.
Comment 5 Wenson Hsieh 2021-04-22 17:13:39 PDT 
Created attachment 426870 [details]
Followup tweak
Comment 6 Radar WebKit Bug Importer 2021-04-22 17:52:06 PDT 
<rdar://problem/77048060>
Comment 7 EWS 2021-04-22 19:33:26 PDT 
Committed r276480 (236939@main): <https://commits.webkit.org/236939@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426870 [details].