WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
224883
Introduce helper methods to map FloatQuads to and from content and root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=224883
Summary
Introduce helper methods to map FloatQuads to and from content and root view ...
Wenson Hsieh
Reported
2021-04-21 12:05:13 PDT
.
Attachments
Patch
(9.57 KB, patch)
2021-04-21 13:15 PDT
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
Followup tweak
(1.68 KB, patch)
2021-04-22 17:13 PDT
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2021-04-21 13:15:06 PDT
Created
attachment 426735
[details]
Patch
EWS
Comment 2
2021-04-21 16:06:57 PDT
Committed
r276397
(
236872@main
): <
https://commits.webkit.org/236872@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 426735
[details]
.
Darin Adler
Comment 3
2021-04-22 16:51:19 PDT
Comment on
attachment 426735
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=426735&action=review
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1076 > + for (size_t i = 0; i < quads.size(); ++i) > + quads[i] = view->contentsToRootView(quads[i]);
range-based for loop here: for (auto& quad : quads) quad = ->contentsToRootView(quad);
Wenson Hsieh
Comment 4
2021-04-22 17:13:38 PDT
Reopening to attach new patch.
Wenson Hsieh
Comment 5
2021-04-22 17:13:39 PDT
Created
attachment 426870
[details]
Followup tweak
Radar WebKit Bug Importer
Comment 6
2021-04-22 17:52:06 PDT
<
rdar://problem/77048060
>
EWS
Comment 7
2021-04-22 19:33:26 PDT
Committed
r276480
(
236939@main
): <
https://commits.webkit.org/236939@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 426870
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug