Bug 224877 - server_process_unittest.py's MockFile should all be bytes
Summary: server_process_unittest.py's MockFile should all be bytes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
Keywords: InRadar
Depends on:
Blocks: 224638
  Show dependency treegraph
Reported: 2021-04-21 10:15 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-22 07:49 PDT (History)
4 users (show)

See Also:

Patch (1.23 KB, patch)
2021-04-21 10:19 PDT, Sam Sneddon [:gsnedders]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-21 10:15:43 PDT
This can't happen under our current testing setup, but playing with pytest locally on Python 3 I hit:

                if out_fd in read_fds:
                    data = self._proc.stdout.read()
                    if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
                        _log.debug('{} because of no data while reading stdout for the server process.'.format(self._crash_message))
                        self._crashed = True
    >               self._output += data
    E               TypeError: can't concat str to bytes
    port/server_process.py:307: TypeError
Comment 1 Radar WebKit Bug Importer 2021-04-21 10:16:03 PDT
Comment 2 Sam Sneddon [:gsnedders] 2021-04-21 10:19:12 PDT
Created attachment 426709 [details]
Comment 3 EWS 2021-04-22 07:49:01 PDT
Committed r276435 (236898@main): <https://commits.webkit.org/236898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426709 [details].