ASSERTION FAILED: context().isInitialized() ./Modules/webaudio/OfflineAudioDestinationNode.cpp(142): Thread 9 Crashed:: WebCore: AudioWorklet 0 com.apple.JavaScriptCore 0x0000000747259d3e WTFCrash + 14 (Assertions.cpp:305) 1 com.apple.WebCore 0x000000072922b87b WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:671) 2 com.apple.WebCore 0x000000072b6f197f WebCore::OfflineAudioDestinationNode::offlineRender() + 367 (OfflineAudioDestinationNode.cpp:142) 3 com.apple.WebCore 0x000000072b70c673 WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_3::operator()() + 35 (OfflineAudioDestinationNode.cpp:103) 4 com.apple.WebCore 0x000000072b70c649 WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_4::operator()(WebCore::ScriptExecutionContext&) + 25 (OfflineAudioDestinationNode.cpp:124) 5 com.apple.WebCore 0x000000072b70c5a3 WTF::Detail::CallableWrapper<WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_4, void, WebCore::ScriptExecutionContext&>::call(WebCore::ScriptExecutionContext&) + 51 (Function.h:52) 6 com.apple.WebCore 0x000000072b9bd16a WTF::Function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const + 154 (Function.h:83) 7 com.apple.WebCore 0x000000072b9a89ad WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext&) + 29 (ScriptExecutionContext.h:203) 8 com.apple.WebCore 0x000000072e13e9d0 WebCore::WorkerRunLoop::Task::performTask(WebCore::WorkerOrWorkletGlobalScope*) + 128 (WorkerRunLoop.cpp:270) 9 com.apple.WebCore 0x000000072e13e037 WebCore::WorkerRunLoop::runInMode(WebCore::WorkerOrWorkletGlobalScope*, WebCore::ModePredicate const&, WebCore::WorkerRunLoop::WaitMode) + 871 (WorkerRunLoop.cpp:209) 10 com.apple.WebCore 0x000000072e13d058 WebCore::WorkerRunLoop::run(WebCore::WorkerOrWorkletGlobalScope*) + 88 (WorkerRunLoop.cpp:143) 11 com.apple.WebCore 0x000000072e13cff8 WebCore::WorkerOrWorkletThread::runEventLoop() + 56 (WorkerOrWorkletThread.cpp:89) 12 com.apple.WebCore 0x000000072e13d2b0 WebCore::WorkerOrWorkletThread::workerOrWorkletThread() + 544 (WorkerOrWorkletThread.cpp:146) 13 com.apple.WebCore 0x000000072b6af4ab WebCore::AudioWorkletThread::createThread()::$_7::operator()() const + 27 (AudioWorkletThread.cpp:68) 14 com.apple.WebCore 0x000000072b6af43e WTF::Detail::CallableWrapper<WebCore::AudioWorkletThread::createThread()::$_7, void>::call() + 30 (Function.h:52) 15 com.apple.JavaScriptCore 0x0000000747282712 WTF::Function<void ()>::operator()() const + 130 (Function.h:83) 16 com.apple.JavaScriptCore 0x0000000747338fd8 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 424 (Threading.cpp:183) 17 com.apple.JavaScriptCore 0x00000007473451a8 WTF::wtfThreadEntryPoint(void*) + 24 (ThreadingPOSIX.cpp:241) 18 libsystem_pthread.dylib 0x00007fff203868fc _pthread_start + 224 19 libsystem_pthread.dylib 0x00007fff20382443 thread_start + 15
<rdar://76896256>
Created attachment 426707 [details] Patch
Comment on attachment 426707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426707&action=review > Source/WebCore/ChangeLog:12 > + worket is used, m_renderThread is null and no synchronization with the AudioWorklet s/worket/worklet/g. > Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:86 > + BinarySemaphore semaphore; Looks like we can use `callOnMainRunLoopAndWait` here? I mean without the semaphore.
Comment on attachment 426707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426707&action=review >> Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:86 >> + BinarySemaphore semaphore; > > Looks like we can use `callOnMainRunLoopAndWait` here? I mean without the semaphore. No because I am not dispatching to the main RunLoop. I am dispatching to the AudioWorklet thread's RunLoop.
Created attachment 426710 [details] Patch
Committed r276379 (236854@main): <https://commits.webkit.org/236854@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426710 [details].