Bug 22487 - Add testcase for FILL_UNSET_PROPERTY macro (and fix crash)
Summary: Add testcase for FILL_UNSET_PROPERTY macro (and fix crash)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 08:53 PST by Simon Fraser (smfr)
Modified: 2009-03-02 11:51 PST (History)
0 users

See Also:

Attachments
Testcase (2.38 KB, text/html)
2008-11-25 08:53 PST, Simon Fraser (smfr) 		no flags Details
Specific test for empty/single-key keyframes (586 bytes, text/html)
2008-11-25 15:12 PST, Simon Fraser (smfr) 		no flags Details
Patch, including LayoutTest files (6.69 KB, patch)
2008-11-25 15:49 PST, Chris Marrin 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-11-25 08:53:13 PST 
We should add a testcase that exercises the logic in the FILL_UNSET_PROPERTY macro for animations/transitions.
Comment 1 Simon Fraser (smfr) 2008-11-25 08:53:38 PST 
Created attachment 25483 [details]
Testcase

Here's the testcase. It currently crashes.
Comment 2 Simon Fraser (smfr) 2008-11-25 08:56:07 PST 
Also, I think this testcase should live in LayoutTests/animations, and not css3/
Comment 3 Simon Fraser (smfr) 2008-11-25 15:12:27 PST 
Created attachment 25507 [details]
Specific test for empty/single-key keyframes
Comment 4 Chris Marrin 2008-11-25 15:49:32 PST 
Created attachment 25508 [details]
Patch, including LayoutTest files

Fix for a null deref bug. I was not checking for 0 length keyframe lists. This patch includes both tests added to this bug.
Comment 5 Simon Fraser (smfr) 2008-11-25 20:53:50 PST 
Fixed: http://trac.webkit.org/changeset/38776