Bug 224847 - Long-pressing a data detectors link causes the link to be followed
Summary: Long-pressing a data detectors link causes the link to be followed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-20 18:36 PDT by Tim Horton
Modified: 2021-04-21 00:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (21.33 KB, patch)
2021-04-20 18:39 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.51 KB, patch)
2021-04-20 19:26 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (24.79 KB, patch)
2021-04-20 23:50 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-04-20 18:36:09 PDT 
Long-pressing a data detectors link causes the link to be followed
Comment 1 Tim Horton 2021-04-20 18:39:37 PDT 
Created attachment 426628 [details]
Patch
Comment 2 Tim Horton 2021-04-20 18:40:02 PDT 
<rdar://problem/72889738>
Comment 3 Tim Horton 2021-04-20 19:26:43 PDT 
Created attachment 426633 [details]
Patch
Comment 4 Wenson Hsieh 2021-04-20 19:32:58 PDT 
Comment on attachment 426633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426633&action=review

r=mews

> Source/WebKit/Shared/NativeWebMouseEvent.h:73
> +    NativeWebMouseEvent(Type, Button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, float deltaX, float deltaY, float deltaZ, int clickCount, OptionSet<Modifier>, WallTime timestamp, double force, bool gestureCancelled);

Should `gestureCancelled` be an enum class type instead of a bool?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:251
> +    RetainPtr<WKTestingTouch> touch = adoptNS([[WKTestingTouch alloc] init]);

Nit - auto?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:255
> +    RetainPtr<WKTestingEvent> event = adoptNS([[WKTestingEvent alloc] init]);

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:268
> +    [webView _doAfterProcessingAllPendingMouseEvents:^{

Nit - this could be made slightly cleaner by using `[webView waitForPendingMouseEvents];`

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:291
> +    RetainPtr<WKTestingTouch> touch = adoptNS([[WKTestingTouch alloc] init]);

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:295
> +    RetainPtr<WKTestingEvent> event = adoptNS([[WKTestingEvent alloc] init]);

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:308
> +    [webView _doAfterProcessingAllPendingMouseEvents:^{

(Ditto)
Comment 5 Tim Horton 2021-04-20 23:50:01 PDT 
Created attachment 426652 [details]
Patch
Comment 6 EWS 2021-04-21 00:38:29 PDT 
Committed r276351 (236829@main): <https://commits.webkit.org/236829@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426652 [details].