RESOLVED FIXED 224843
GPUProcess launches unnecessarily when loading the amazon front page
https://bugs.webkit.org/show_bug.cgi?id=224843
Summary GPUProcess launches unnecessarily when loading the amazon front page
Chris Dumez
Reported 2021-04-20 17:04:04 PDT
GPUProcess launches unnecessarily when load the amazon front page. The Amazon front page is only using the HTMLMediaElement for feature detection, there should not be any need to launch the GPUProcess in this case: ``` l = { audio: function() { return !!h.createElement("audio").canPlayType }, video: function() { return !!h.createElement("video").canPlayType }, ```
Attachments
WIP Patch (34.41 KB, patch)
2021-04-20 17:05 PDT, Chris Dumez
ews-feeder: commit-queue-
WIP Patch (34.44 KB, patch)
2021-04-20 19:00 PDT, Chris Dumez
no flags
WIP Patch (34.52 KB, patch)
2021-04-20 19:26 PDT, Chris Dumez
ews-feeder: commit-queue-
WIP Patch (38.22 KB, patch)
2021-04-21 08:09 PDT, Chris Dumez
no flags
Patch (47.30 KB, patch)
2021-04-21 08:26 PDT, Chris Dumez
no flags
Patch (4.88 KB, patch)
2021-04-21 10:13 PDT, Chris Dumez
no flags
Patch (47.39 KB, patch)
2021-04-21 11:29 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2021-04-20 17:05:06 PDT
Created attachment 426618 [details] WIP Patch Works on iPad with amazon.com (no GPUProcess). Will do more testing and polish the patch tomorrow.
Chris Dumez
Comment 2 2021-04-20 17:19:07 PDT
I am currently A/B testing the change on PLUM3.
Chris Dumez
Comment 3 2021-04-20 19:00:03 PDT
Created attachment 426630 [details] WIP Patch
Chris Dumez
Comment 4 2021-04-20 19:26:54 PDT
Created attachment 426634 [details] WIP Patch
Chris Dumez
Comment 5 2021-04-21 08:09:27 PDT
Created attachment 426690 [details] WIP Patch Should hopefully pass all the tests now. This seems to be a ~3.6% PLUM progression on iPhone so definitely worth pursuing.
Chris Dumez
Comment 6 2021-04-21 08:26:06 PDT
Chris Dumez
Comment 7 2021-04-21 10:13:34 PDT
Chris Dumez
Comment 8 2021-04-21 11:29:54 PDT
Eric Carlson
Comment 9 2021-04-21 13:28:22 PDT
Comment on attachment 426716 [details] Patch This is great, thanks Chris!
EWS
Comment 10 2021-04-21 13:53:09 PDT
Committed r276389 (236864@main): <https://commits.webkit.org/236864@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426716 [details].
Chris Dumez
Comment 11 2021-04-21 19:30:48 PDT
One of the last minute changes I made to fix a layout test must have messed thing up because this patch wasn't a progression when it landed. I had tested the earlier version of my patch and it was a progression so I will have to investigate tomorrow.
Chris Dumez
Comment 12 2021-04-22 08:16:25 PDT
(In reply to Chris Dumez from comment #11) > One of the last minute changes I made to fix a layout test must have messed > thing up because this patch wasn't a progression when it landed. I had > tested the earlier version of my patch and it was a progression so I will > have to investigate tomorrow. Looking deeper into A/B testing for this latest patch, I see that it did what I expected it to do. With the patch, there is no GPUProcess on amazon.com-front & amazon.com-search. Before the patch, there was a GPUProcess *before* the memory warning on both these pages. A/B testing indicates we get a ~1% progression (with 98% probability) on both of these pages. However, it doesn't seem this is sufficient to show a progression on the overall score (despite no other page regressing).
Ling Ho
Comment 13 2021-04-22 16:16:21 PDT
Note You need to log in before you can comment on or make changes to this bug.