Bug 224839 – REGRESSION(r256107): Text moves around when selecting at https://www.tokyo-sports.co.jp/entame/news/2834187/

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://74958484>

[zalan]

Created attachment 426606 [details]
Patch

[Darin Adler]

Comment on attachment 426606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426606&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83
>      auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox);

"preseve"

> Source/WebCore/layout/inlineformatting/text/TextUtil.h:57
> +    static LineBreakIteratorMode lineBreakIteratorMode(LineBreak);

Not the biggest fan of a class and file named TextUtil.

[zalan]

(In reply to Darin Adler from comment #2)
> Comment on attachment 426606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426606&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83
> >      auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox);
> 
> "preseve"
> 
> > Source/WebCore/layout/inlineformatting/text/TextUtil.h:57
> > +    static LineBreakIteratorMode lineBreakIteratorMode(LineBreak);
> 
> Not the biggest fan of a class and file named TextUtil.
Me neither. It should have been renamed long time ago. Will take care of it.

[zalan]

Created attachment 426629 [details]
Patch

[EWS]

Committed r276357 (236835@main): <https://commits.webkit.org/236835@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426629 [details].