Bug 224839 - REGRESSION(r256107): Text moves around when selecting at https://www.tokyo-sports.co.jp/entame/news/2834187/
Summary: REGRESSION(r256107): Text moves around when selecting at https://www.tokyo-sp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-20 15:53 PDT by zalan
Modified: 2021-04-26 13:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.89 KB, patch)
2021-04-20 15:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.86 KB, patch)
2021-04-20 18:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-04-20 15:53:58 PDT 
<rdar://74958484>
Comment 1 zalan 2021-04-20 15:57:42 PDT 
Created attachment 426606 [details]
Patch
Comment 2 Darin Adler 2021-04-20 18:28:04 PDT 
Comment on attachment 426606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426606&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83
>      auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox);

"preseve"

> Source/WebCore/layout/inlineformatting/text/TextUtil.h:57
> +    static LineBreakIteratorMode lineBreakIteratorMode(LineBreak);

Not the biggest fan of a class and file named TextUtil.
Comment 3 zalan 2021-04-20 18:39:39 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 426606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426606&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83
> >      auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox);
> 
> "preseve"
> 
> > Source/WebCore/layout/inlineformatting/text/TextUtil.h:57
> > +    static LineBreakIteratorMode lineBreakIteratorMode(LineBreak);
> 
> Not the biggest fan of a class and file named TextUtil.
Me neither. It should have been renamed long time ago. Will take care of it.
Comment 4 zalan 2021-04-20 18:57:51 PDT 
Created attachment 426629 [details]
Patch
Comment 5 EWS 2021-04-21 06:36:41 PDT 
Committed r276357 (236835@main): <https://commits.webkit.org/236835@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426629 [details].