Bug 224838 – [SOUP] Null pointer dereference in ResourceLoader::didReceiveAuthenticationChallenge

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

[840/1793] Building CXX object Source/WebCore/CMakeFiles/...vedSources/unified-sources/UnifiedSource-c57e08af-6.cpp.o
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-c57e08af-6.cpp:3:
../../Source/WebCore/loader/ResourceLoader.cpp: In member function ‘virtual void WebCore::ResourceLoader::didReceiveAuthenticationChallenge(WebCore::ResourceHandle*, const WebCore::AuthenticationChallenge&)’:
../../Source/WebCore/loader/ResourceLoader.cpp:809:81: warning: ‘this’ pointer is null [-Wnonnull]
  809 |     challenge.authenticationClient()->receivedRequestToContinueWithoutCredential(challenge);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

At first I incorrectly thought this was a false positive, but in bug #224452, Chris noticed that our AuthenticationChallenge::authenticationClient now always returns nullptr. That is no good. Carlos, I guess this is not quite what you had intended?

[Carlos Garcia Campos]

I think that code is never actually reached, that's only used by ResourceHandle which is no longer supported by the soup based ports. The soup implementation of ResourceHandle::receivedRequestToContinueWithoutCredential() is an assert.

[Michael Catanzaro]

Created attachment 426825 [details]
Patch

[EWS]

Committed r276471 (236931@main): <https://commits.webkit.org/236931@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426825 [details].