Bug 224834 - [Cocoa] Prevent GPU and WebContent processes from attempting to connect to the AppSSO service
Summary: [Cocoa] Prevent GPU and WebContent processes from attempting to connect to th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 226393
  Show dependency tree / graph
 
Reported: 2021-04-20 15:29 PDT by Brent Fulgham
Modified: 2021-05-28 14:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2021-04-20 15:33 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (4.87 KB, patch)
2021-04-20 16:29 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-04-20 15:29:29 PDT 
CFNetwork will attempt to check in with the AppSSO service under certain load operations. But WebKit handles the AppSSO flow prior to load, and hand the necessary state to CFNetwork to control loads. We don't want CFNetwork to attempt to connect to AppSSO on its own.

We need to tell CFNetwork that we've already make the assessment of whether AppSSO is needed so that it doesn't attempt to reach out on its own.
Comment 1 Brent Fulgham 2021-04-20 15:29:49 PDT 
<rdar://problem/72157514>
Comment 2 Brent Fulgham 2021-04-20 15:33:48 PDT 
Created attachment 426601 [details]
Patch
Comment 3 Jiewen Tan 2021-04-20 16:06:46 PDT 
Comment on attachment 426601 [details]
Patch

LGTM. r=me.
Comment 4 Brent Fulgham 2021-04-20 16:29:19 PDT 
Created attachment 426612 [details]
Patch for landing
Comment 5 EWS 2021-04-20 18:05:38 PDT 
Committed r276340 (236818@main): <https://commits.webkit.org/236818@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426612 [details].