Bug 224829 – If an idle GPUProcess doesn't exit under memory pressure because it just launched, check again later

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

If an idle GPUProcess doesn't exit under memory pressure because it just launched, check again later. This is a follow-up to r276305.

[Chris Dumez]

Created attachment 426594 [details]
Patch

[Darin Adler]

Comment on attachment 426594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426594&action=review

> Source/WebKit/GPUProcess/GPUProcess.cpp:155
>      return true;

Should we do m_idleExitTimer.stop() here too?

[Chris Dumez]

Comment on attachment 426594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426594&action=review

>> Source/WebKit/GPUProcess/GPUProcess.cpp:155
>>      return true;
> 
> Should we do m_idleExitTimer.stop() here too?

Hmm. In this case, we will end up exiting anyway, but sure, it feels a bit cleaner to stop the timer in this case too.

[Chris Dumez]

Created attachment 426600 [details]
Patch

[Chris Dumez]

Created attachment 426602 [details]
Patch

[Chris Dumez]

I made the suggested change. I am asking for review again because I made a significant change. I moved the whole logic from canExitUnderMemoryPressure() to tryExitIfUnused(). It feels much nicer for tryExitIfUnused() to schedule a timer to call tryExitIfUnused() then a simple query function like canExitUnderMemoryPressure().

[EWS]

Committed r276339 (236817@main): <https://commits.webkit.org/236817@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426602 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77061558>