Bug 224815 - Fix isCSSWideKeyword to stop including `default`
Summary: Fix isCSSWideKeyword to stop including `default`
Status: RESOLVED DUPLICATE of bug 232750
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2021-04-20 08:41 PDT by Tim Nguyen (:ntim)
Modified: 2021-11-06 09:09 PDT (History)
8 users (show)

See Also:

Patch (2.66 KB, patch)
2021-04-20 08:52 PDT, Tim Nguyen (:ntim)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.39 KB, patch)
2021-04-20 09:01 PDT, Tim Nguyen (:ntim)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-04-20 08:41:55 PDT
I discovered that isCSSWideKeywords included CSSValueDefault, which was slightly surprising. 

Antti mentioned this was because `default` used to be the old name for `revert`.

Since this is not supported in any browser, let's remove it.
Comment 1 Radar WebKit Bug Importer 2021-04-20 08:43:21 PDT
Comment 2 Tim Nguyen (:ntim) 2021-04-20 08:52:43 PDT
Created attachment 426551 [details]
Comment 3 Tim Nguyen (:ntim) 2021-04-20 09:01:54 PDT
Created attachment 426552 [details]
Comment 4 Darin Adler 2021-04-25 10:35:43 PDT
I think it’s important to talk about the observable change we want in behavior rather than the internal function name. Do we have a test for the case where we end up handling "default" incorrectly?

I still fully expect this will end up being a useful change once we understand why the tests we already have start indicating a failure and take care of that. We may need a different internal function to use where we are currently using isCSSWideKeyword.
Comment 5 Tim Nguyen (:ntim) 2021-11-06 09:08:31 PDT

*** This bug has been marked as a duplicate of bug 232750 ***